Bugzilla – Bug 14456
empty album list for artist on controller
Last modified: 2009-10-13 21:09:43 UTC
It's works like this on my controller. I scroll down the my music artist listartist list to " Steve Earle" push > look at my five steve Earle Album's all OK. Then i just scroll down one artist, then up again and wehn i look into0 steve earle again its empty !! no albums . I can repeat this almost everywhere in my artist list. The first artist A,B.. someting is ok then it breaks around "G" for me. go to artist Z look into this artist albums, it's fine they are there return to artist list scroll down scroll back up look at artist Z again and it's empty These artist's have no albums until you reboot the controller. I'm on latest 7.4.1 and controller is 7.4 -7790 If browse by albums you still see the albums and if use + context menu you still browse to that artists albums and see them all? Or this very convoluted way, use bmf use context menu on a track with a "disappeared" browse to the artist from there, then you can see the tracks again ? If I restart the controller this the albums re-apear
reproduced easily. this is a bad one and needs an immediate fix.
Created attachment 5958 [details] suggested fix Tom is investigating a bit further, but so it does not get lost this is the suggested fix.
Created attachment 5959 [details] suggested fix wrong patch originally...it's this one
Created attachment 5968 [details] updated patch
Fix attached, for Ben's review. There were global objects held on player related to browse history, that could easily get clobbered if two steps were being loaded simultaneously. Those have been moved inside the step. Also, the browse history is now cleared when a player:free() happens, so that when switching servers for a given player, the browse history resets.... See related bug 14478 regarding browse history preservation between server disconnects.
Tom's patch is a fairly involved one, but I've reviewed it and feel it looks good. I also tested the patch and the issue described in this bug is no longer seen. Assigning back to you Tom, my feeling is that this should go into the next release- 7.4.1.
== Auto-comment from SVN commit #7839 to the jive repo by tom == == https://svn.slimdevices.com/jive?view=revision&revision=7839 == Bug: 14456 Description: - last browse code used player global values that would get clobbered, now tied to step.
can you do a final check for us? download the patched version of SBS 7.4.1 which will include the latest controller firmware. Install this version then test your case again. let me know if this works or fails. download from here: http://downloads.slimdevices.com/nightly/?ver=7.4
This is working /has been ok since you patched it . I'm on 7.4.1 so upgrades have kept coming and this have been ok the last weeks
Thanks for the verification.