Bug 14437 – LocalPlayer.lua:214: attempt to index field 'slimproto'

Bug 14437 - LocalPlayer.lua:214: attempt to index field 'slimproto'

Summary:

LocalPlayer.lua:214: attempt to index field 'slimproto'

Status:	CLOSED FIXED

Product:	SqueezePlay
Classification:	Unclassified
Component:	Audio
Version:	unspecified
Platform:	PC Windows XP

Importance:	P4 normal (vote)
Target Milestone:	7.6.0
Assigned To:	Bradley D. Wall

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-09-30 02:26 UTC by Richard Titmuss
Modified:	2011-05-23 15:52 UTC (History)
CC List:	3 users (show)

See Also:
Category:	---

Attachments
nil protection (1.27 KB, patch) 2009-10-01 11:48 UTC, Wadzinski Tom	Details \| Diff
updated (1.27 KB, patch) 2009-10-01 11:55 UTC, Wadzinski Tom	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Richard Titmuss 2009-09-30 02:26:38 UTC

Protection needed in case slimproto is nil, in several places. From crash logs:


Machine: jive
Version: 7.4.0 r7790

Sep 29 09:24:38 squeezeplay: WARN   squeezeplay.timer - Timer.lua:193 timer error: /usr/share/jive/jive/slim/LocalPlayer.lua:214: attempt to index field 'slimproto' (a nil value)
Sep 29 09:24:38 squeezeplay: WARN   squeezeplay.timer - Timer.lua:193 timer error: /usr/share/jive/jive/slim/LocalPlayer.lua:214: attempt to index field 'slimproto' (a nil value)
Sep 29 09:24:38 squeezeplay: WARN   squeezeplay.timer - Timer.lua:193 timer error: /usr/share/jive/jive/slim/LocalPlayer.lua:214: attempt to index field 'slimproto' (a nil value)
Sep 29 09:24:38 squeezeplay: WARN   squeezeplay.timer - Timer.lua:193 timer error: /usr/share/jive/jive/slim/LocalPlayer.lua:214: attempt to index field 'slimproto' (a nil value)

Comment 1 Wadzinski Tom 2009-10-01 11:48:23 UTC

Patch attached (shortly) for review.  It looks like the only time this happens is when a user deselects enable audio playback(which is the only call to destroy(), which is the only thing that sets slimproto to nil). So, the nil protection doesn't seem like a full solution here, as, for instance, it looks like some other timer is still firing and may well continue to fire until the user reboots.

I think we may want to force/suggest a reboot when a user enables/disables audio playback since this switch either way without reboot brings up a handful of issue not widely tested.

Comment 2 Wadzinski Tom 2009-10-01 11:48:42 UTC

Created attachment 5974 [details]
nil protection

Comment 3 Wadzinski Tom 2009-10-01 11:55:00 UTC

Created attachment 5975 [details]
updated

Comment 4 Chris Owens 2010-03-15 18:05:15 UTC

7.4.x milestone is in the past

Comment 5 Chris Owens 2010-05-07 10:28:51 UTC

Richard is no longer available to us.

Comment 6 Ben Klaas 2011-01-17 09:21:28 UTC

Tom's patch is very low risk. Will check in for 7.6.0

Comment 7 SVN Bot 2011-01-17 13:27:58 UTC

 == Auto-comment from SVN commit #9287 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=9287 ==

Fixed Bug: 14437
Description: test for self.slimproto before executing methods on that object

Comment 8 Mickey Gee 2011-05-23 09:25:56 UTC

Bug fixed, but not sure about repro steps. User must disable audio playback on Squeezebox Controller by going into Settings->Advanced->Beta Features->Audio Playback and check/uncheck enable playback. Then play music on your Controller headphone output jack and ensure Controller doesn't crash.

Comment 9 Bradley D. Wall 2011-05-23 15:52:38 UTC

 Verified fixed in Controller.  
Closing