Bug 14358 - Playing Last.fm from TrackInfo menu doesn't work
: Playing Last.fm from TrackInfo menu doesn't work
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Last.fm
: 7.4.0
: PC Other
: P1 normal (vote)
: 7.5.0
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-28 06:31 UTC by Joerg Schwieder
Modified: 2010-04-08 17:25 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joerg Schwieder 2009-09-28 06:31:46 UTC
This is r28660

I can't play a Last.fm station when I browse there from the TrackInfo menu out of the current playlist.

It works fine if I go through the MyApps menu.

I'm seeing the same thing when using iPeng or the Controller, the menus, commands and server responses are as follows:

Controller:
[09-09-28 15:19:18.8994] Slim::Web::Cometd::handler (143) Cometd request: [
  {
    channel => "/slim/request",
    data => {
          request  => [
                        "00:04:20:10:11:0d",
                        [
                          "trackinfo",
                          "playlist",
                          "play",
                          "favorites_title:Play Similar Artists Radio",
                          "favorites_url:lfm://artist/M.I.A./similarartists",
                          "isContextMenu:1",
                          "item_id:4a650e68.21.0.0",
                          "type:audio",
                          "useContextMenu:1",
                        ],
                      ],
          response => "/1667ea2a/slim/request",
        },
    id => 13,
  },
]
[09-09-28 15:19:18.9031] Slim::Web::Cometd::sendHTTPResponse (662) Sending Cometd Response:
HTTP/1.1 200 OK
Cache-Control: no-cache
Pragma: no-cache
Content-Length: 107
Content-Type: application/json
Expires: -1

[{"error":"request failed with error: Bad params!","id":"13","channel":"/slim/request","successful":false}]

iPeng:
[09-09-28 15:11:16.3641] Slim::Web::Cometd::handler (143) Cometd request: [
  {
    channel => "/slim/request",
    data => {
          request  => [
                        "00:04:20:10:11:0d",
                        ["trackinfo", "playlist", "play", "item_id:fa3ba1e1.21.0.0"],
                      ],
          response => "/9a00fbcf/slim/request",
        },
    id => 2968,
  },
]
[09-09-28 15:11:16.3676] Slim::Web::Cometd::sendHTTPResponse (662) Sending Cometd Response:
HTTP/1.1 200 OK
Cache-Control: no-cache
Connection: keep-alive
Pragma: no-cache
Content-Length: 109
Content-Type: application/json
Expires: -1

[{"error":"request failed with error: Bad params!","id":"2968","channel":"/slim/request","successful":false}]

The menu is:
[09-09-28 15:19:13.7547] Slim::Web::Cometd::Manager::deliver_events (228) Delivering events to 1667ea2a:
do {
  my $a = [
    {
      channel => "/1667ea2a/slim/request",
      data => {
            base      => {
                           actions => {
                                 add => {
                                       cmd => ["trackinfo", "playlist", "add"],
                                       itemsParams => "params",
                                       params => {
                                             menu => "trackinfo",
                                             track_id => 5849,
                                             url => "file:///mnt/slugpublic/Media/Music/M.I.A/Kala/10%20XR2.mp3",
                                           },
                                       player => 0,
                                     },
                                 "add-hold" => {
                                       cmd => ["trackinfo", "playlist", "insert"],
                                       itemsParams => "params",
                                       params => 'fix',
                                       player => 0,
                                     },
                                 go => { cmd => ["trackinfo", "items"], itemsParams => "params", params => 'fix' },
                                 more => {
                                       cmd => ["trackinfo", "items"],
                                       itemsParams => "params",
                                       params => 'fix',
                                       player => 0,
                                       window => { isContextMenu => 1 },
                                     },
                                 play => {
                                       cmd => ["trackinfo", "playlist", "play"],
                                       itemsParams => "params",
                                       nextWindow => "nowPlaying",
                                       params => 'fix',
                                       player => 0,
                                     },
...
                               },
                         },
            count     => 5,
            item_loop => [
                           {
                             actions    => {
                                             add => {
                                                   cmd => ["trackinfo", "playlist", "add"],
                                                   itemsParams => "params",
                                                   params => {
                                                         favorites_title => "Play Similar Artists Radio",
                                                         favorites_url => "lfm://artist/M.I.A./similarartists",
                                                         isContextMenu => 1,
                                                         item_id => "4a650e68.21.0.0",
                                                         type => "audio",
                                                       },
                                                   player => 0,
                                                 },
                                             "add-hold" => {
                                                   cmd => ["trackinfo", "playlist", "insert"],
                                                   itemsParams => "params",
                                                   params => 'fix',
                                                   player => 0,
                                                 },
                                             go => {
                                                   cmd => ["trackinfo", "playlist", "play"],
                                                   itemsParams => "params",
                                                   nextWindow => "nowPlaying",
                                                   params => 'fix',
                                                   player => 0,
                                                 },
                                             more => {
                                                   cmd => ["trackinfo", "items"],
                                                   itemsParams => "params",
                                                   params => {
                                                         favorites_title => "Play Similar Artists Radio",
                                                         favorites_url => "lfm://artist/M.I.A./similarartists",
                                                         isContextMenu => 1,
                                                         item_id => "4a650e68.21.0.0",
                                                         menu => "trackinfo",
                                                         track_id => 5849,
                                                         type => "audio",
                                                         url => "file:///mnt/slugpublic/Media/Music/M.I.A/Kala/10%20XR2.mp3",
                                                       },
                                                 },
                                           },
                             params     => 'fix',
                             playAction => "go",
                             style      => "itemplay",
                             text       => "Play Similar Artists Radio",
                           },
Comment 1 Joerg Schwieder 2009-09-28 06:43:04 UTC
I should add the menu path:
Current Track->TrackInfo->On Last.fm Radio-><artist>->Play Similar Artist Radio

I believe the Controller follows the "do" command or does "play" (can't tell what TTP would do, they are the same commands). iPeng calls the Context Menu first and then executes "play" on the "play" item.

As I said: neither way works.
Comment 2 SVN Bot 2009-12-16 01:56:24 UTC
 == Auto-comment from SVN commit #29619 to the slim repo by michael ==
 == https://svn.slimdevices.com/slim?view=revision&revision=29619 ==

Fixed Bug: 14358
Description: use distinct method for trackinfo playlist commands; use cached feed
Comment 3 Andy Grundman 2010-02-19 11:40:55 UTC
Fixed target, this was not fixed in 7.4.
Comment 4 Chris Owens 2010-04-08 17:25:57 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!