Bug 14353 – power off does not silence Baby if SBS down

Bug 14353 - power off does not silence Baby if SBS down

Summary:

power off does not silence Baby if SBS down

Status:	VERIFIED FIXED

Product:	SB Radio
Classification:	Unclassified
Component:	Menus
Version:	Include FW version in comment
Platform:	All All

Importance:	P1 normal (vote)
Target Milestone:	7.4.1
Assigned To:	Richard Titmuss

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-09-27 20:54 UTC by Peter Watkins
Modified:	2010-05-27 14:45 UTC (History)
CC List:	3 users (show)

See Also:
Category:	Bug

Attachments
patch for Richard's review (2.36 KB, patch) 2009-10-02 05:18 UTC, Wadzinski Tom	Details \| Diff
updated (removed bogus comment) (2.10 KB, patch) 2009-10-02 05:29 UTC, Wadzinski Tom	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Watkins 2009-09-27 20:54:52 UTC

0) started an SBS 7.4.0 (SVN 28664) instance with --failsafe
1) started playing an internet radio stream on Baby (PB1 @ firmware r7779)
2) kill SBS instance
3) noted the "Connetcing to $servername" spinny
4) ignoring the spinny, pressed power button on Baby
5) Baby's screen goes dark (as configured in screensavers)

The music keeps playing. Shouldn't SqueezePlay be smart/fat enough to know to stop playing?

Comment 1 James Richardson 2009-09-30 13:08:52 UTC

Doing the same steps as above, leaving out STEP 2, Radio will properly stop audio playback before going into sleep mode

Doing the same steps above, doing a long-press to power down Radio will properly power off Radio

Comment 2 Wadzinski Tom 2009-10-02 05:18:56 UTC

Created attachment 5981 [details]
patch for Richard's review

Comment 3 Wadzinski Tom 2009-10-02 05:29:05 UTC

Richard, I attached a patch for your review. I believe we had planned this to be 7.4.1, please confirm.

Before the patch, only if player:isConnected() was true would power commands happen (which in the local player case also pauses music).  I believe I had coded it that way to try to gracefully deal with the disconnected remote player case, which is tricky and still undesigned). But for local players, the problem is simpler.   So, now I also send power commands if player:isConnected or player:isLocal()

and inside localPlayer I added a check in the rare case that the local player has no slimserver object (connected or not).

Note: Jive is unaffected by these changes because jive does have a soft power capability.

Comment 4 Wadzinski Tom 2009-10-02 05:29:29 UTC

Created attachment 5982 [details]
updated (removed bogus comment)

Comment 5 SVN Bot 2009-10-02 05:41:39 UTC

 == Auto-comment from SVN commit #7825 to the jive repo by tom ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7825 ==

Fixed Bug: 14353
Description:
- call power commands for local player even if player is not connected so music stops playing.

Comment 6 James Richardson 2009-10-13 16:47:09 UTC

Verified fixed in r7847

Comment 7 Chris Owens 2010-05-27 14:45:40 UTC

These bugs have all been marked resolved and belong to a component which is being removed.  Therefore they have been moved to the most applicable of the new components.