Bugzilla – Bug 14337
Controller just says "squeezebox" with spinny while receiver updates its firmware (r7760)
Last modified: 2009-10-21 09:45:53 UTC
I still see this with firmware r7790 on Controller. It just says Squeezebox or the player name with a spinny above, it really ought to say updating firmware.
Use "Updating Squeezebox fw" string
This is a trivial fix. Both labels were being named with the variable name and then only one widget was being added to the window. Richard, yours for review and then I'll checkin. === SlimMenus/SlimMenusApplet.lua ================================================================== --- SlimMenus/SlimMenusApplet.lua (revision 36520) +++ SlimMenus/SlimMenusApplet.lua (local) @@ -198,9 +198,10 @@ local popup = Popup("waiting_popup") local icon = Icon("icon_connecting") local label = Label("text", self:string('SLIMBROWSER_UPDATING_FIRMWARE_SQUEEZEBOX')) - local label = Label("subtext", _player:getName()) + local sublabel = Label("subtext", _player:getName()) popup:addWidget(icon) popup:addWidget(label) + popup:addWidget(sublabel) popup:setAlwaysOnTop(true) -- add a listener for KEY_PRESS that disconnects from the player and returns to home
ben, looks good.
== Auto-comment from SVN commit #7831 to the jive repo by bklaas == == https://svn.slimdevices.com/jive?view=revision&revision=7831 == Fixed Bug: 14337 Description: two labels need to be added to the popup to make the text correct here
Verified fixed in SP r7847, SBS r28848, latest release of SN.