Bug 14337 - Controller just says "squeezebox" with spinny while receiver updates its firmware (r7760)
: Controller just says "squeezebox" with spinny while receiver updates its firm...
Status: VERIFIED FIXED
Product: SB Controller
Classification: Unclassified
Component: UI
: unspecified
: PC Windows XP
: P4 normal (vote)
: 7.4.1
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-26 15:43 UTC by Ross Levine
Modified: 2009-10-21 09:45 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Levine 2009-09-26 15:43:29 UTC

    
Comment 1 Ross Levine 2009-09-29 12:51:06 UTC
I still see this with firmware r7790 on Controller. It just says Squeezebox or the player name with a spinny above, it really ought to say updating firmware.
Comment 2 Wadzinski Tom 2009-10-01 12:16:43 UTC
Use "Updating Squeezebox fw" string
Comment 3 Ben Klaas 2009-10-02 07:17:06 UTC
This is a trivial fix. Both labels were being named with the variable name and then only one widget was being added to the window. 

Richard, yours for review and then I'll checkin.

=== SlimMenus/SlimMenusApplet.lua
==================================================================
--- SlimMenus/SlimMenusApplet.lua       (revision 36520)
+++ SlimMenus/SlimMenusApplet.lua       (local)
@@ -198,9 +198,10 @@
        local popup = Popup("waiting_popup")
        local icon  = Icon("icon_connecting")
        local label = Label("text", self:string('SLIMBROWSER_UPDATING_FIRMWARE_SQUEEZEBOX'))
-       local label = Label("subtext", _player:getName())
+       local sublabel = Label("subtext", _player:getName())
        popup:addWidget(icon)
        popup:addWidget(label)
+       popup:addWidget(sublabel)
        popup:setAlwaysOnTop(true)
 
        -- add a listener for KEY_PRESS that disconnects from the player and returns to home
Comment 4 Richard Titmuss 2009-10-02 07:56:23 UTC
ben, looks good.
Comment 5 SVN Bot 2009-10-02 08:03:17 UTC
 == Auto-comment from SVN commit #7831 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7831 ==

Fixed Bug: 14337
Description: two labels need to be added to the popup to make the text correct here
Comment 6 James Richardson 2009-10-14 09:28:13 UTC
Verified fixed in SP r7847, SBS r28848, latest release of SN.