Bugzilla – Bug 14329
Line-in selected and playing, selecting other sources not working right.
Last modified: 2010-05-27 14:46:16 UTC
Behavior is variable. One scenario: With LineIn working, Home>Pandora or Internet Radio. Spinny for longer than normal then 'fetching data' then no sound, no progress bar. Nav around some, bring up CM, eventually get progress bar but no sound. Go back to Home, LineIn is not checked. Another scenario: With LineIn working, Home>Pandora>Your Stations>QuickMix> Brings up album art from QuickMix but audio still from LineIn. Home, shows LineIn still selected. Another scenario: Turn off LineIn, play a pandora station. Select LineIn and play. Home>Pandora>Your Stations>Some other Pandora station> plays 5 to 10 sec of song from previous station then starts song from this station.
If you turn off LineIn before selecting other sources, everything is fine.
Tested again with r7779 and it is not fixed. Chris thought it was better for internet radio but I am not seeing that. I have also hit the *really* bad bug twice in 5 mins where all sounds (nav and music) are killed until reboot. (now 3 times in 10 mins) I also saw (for the first time) the LineIn box checked on the home menu after successfully selecting a Pandora QuickMix. But this is not consistent. Definitely still see scenario 3 (LineIn, select Pandora, a few sec silence, ~8 sec of previous Pandora selection, then new Pandora selection) And scenario 1 (no sound) with Pandora with odd progress bar behavior. And scenario 1 (select Pandora, LineIn keeps playing) And scenario 1 selecting Internet Radio. Eventually got in state where LineIn always kept playing no matter what input I selected. I also once got in a state where a radio station kept playing no matter what station I selected (I am not sure if I tried directly selecting LineIn).
An idea to explore is that there are problems due the regular playback decoding starts before line-in is deactivated. playerstatus is used to deactivate line-in, but that comes after the strm s response which starts the regular playback handling. Instead, in the the 's' handling, if we trigger line-in deactivation there instead, the transition would be smoother. Perhaps a new player notification would be sent at 's' time to indicate playback is starting....
== Auto-comment from SVN commit #7786 to the jive repo by richard == == https://svn.slimdevices.com/jive?view=revision&revision=7786 == Bug #14329 Refactor. Move decode:capture() into Playback, this will allow the state to be correctly handled.
== Auto-comment from SVN commit #7787 to the jive repo by richard == == https://svn.slimdevices.com/jive?view=revision&revision=7787 == Bug #14329 Playback.lua tracks the currect source "stream", "file" or "capture" in the self.stream variable. This change adds a _setSource() that is used when the source changes. The capture on/off is now done in this function, so when starting to stream and capture can be turned off if required. Decode:stop() is also called when enabling capture, this leaves the decoder in the correct state. With this change the audio now works correctly, but the ui is left in the wrong state.
== Auto-comment from SVN commit #7788 to the jive repo by richard == == https://svn.slimdevices.com/jive?view=revision&revision=7788 == Bug #14329 Don't pause the player when starting line-in, stop it.
== Auto-comment from SVN commit #7789 to the jive repo by richard == == https://svn.slimdevices.com/jive?view=revision&revision=7789 == Bug #14329 Don't call decode:stop() on a strm from SC (or the local stop timer) when using a capture source.
== Auto-comment from SVN commit #7790 to the jive repo by richard == == https://svn.slimdevices.com/jive?view=revision&revision=7790 == Bug #14329 Turn off line-in when box is unchecked.
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server! * SqueezeCenter: 28672 * Squeezebox 2 and 3: 130 * Transporter: 80 * Receiver: 65 * Boom: 50 * Controller: 7790 * Radio: 7790 Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
These bugs have all been marked resolved and belong to a component which is being removed. Therefore they have been moved to the most applicable of the new components.