Bugzilla – Bug 14321
Applet Installer shows duplicate entries
Last modified: 2009-10-27 14:29:10 UTC
If a plugin or applet is available in more than one plugin repository there seems to be duplicate entries in Applet Installer. The same scenario in Squeezebox Server, in the Plugins tab, never show duplicate entries, it just shows the highest version. The Applet Installer should work the same way if an applet exists in multiple repositories. I've also seen that if the versions in the repositories differs it once installed the older version after a firmware upgrade. The reason is probably that both entries are marked as "Installed" so it's not clear which one Applet Installer will install in this case. The duplicate entries scenario will typically occur for applets where the developer have a "beta-testing" repository, in this case there might be a version in the "recommended" or "other" list and another version in the "beta-testing" repository. In this case I think users that have setup the "beta-testing" repository should only see the beta version if it has a higher version than the version in the recommended/other lists.
Erland - if we make this work the same way as the plugins page, where the highest weight repo is retained (which are the user added ones) is this what you think is right?
Created attachment 6152 [details] potential patch for removing duplicates Erland - could you try the attached patch. Should add the same duplicate removal logic that exists in the plugin page. In both cases if there is are multiple user provided repos with the same plugin/applet in them, then it will be random which one is selected. Is this ok or should we select the highest version number (is this case real?)
(In reply to comment #2) > Erland - could you try the attached patch. Should add the same duplicate > removal logic that exists in the plugin page. > Seems to work as far as I can see > In both cases if there is are multiple user provided repos with the same > plugin/applet in them, then it will be random which one is selected. Is this > ok or should we select the highest version number (is this case real?) Random is generally a bad idea since it will cause confusing, but this should be a pretty rare case. The only situation I can imagine are people that have setup the a third party repository manually so they don't need to wait for someone with commit access to run the buildrepo.pl script when a new plugin/applet version is released. In this case there might be: - The official repository with the older version - A manually configured repository of the third party developer with the latest version - A manually configured testing repository of the third party developer with the latest beta version The most flexible solution would be to take the one for the last configured repository as this let the user control. The most useful solution would probably be to take the latest version, but in this case I really think it should also compare with the officially repositories included by default and not just between the manually configured repositories. If it gets complex, I'd just ignore this scenario. Are all these problems going to disappear when plugins/applets are made available through Apps on mysqueezebox.com ? If this is the case, it might be a good idea to ignore these special cases in this temporary solution.
Will look at this again next weekend to see if I can improve it as its missed 7.4.1
== Auto-comment from SVN commit #29029 to the slim repo by adrian == == https://svn.slimdevices.com/slim?view=revision&revision=29029 == Bug: 14321, 14657 Description: if the same extension appears in multiple repos, only show the highest version number in applet installer and on the plugin page