Bug 14269 – Cleanup: don't make functionality dependant on player model

Bug 14269 - Cleanup: don't make functionality dependant on player model

Summary:

Cleanup: don't make functionality dependant on player model

Status:	CLOSED FIXED

Product:	SqueezePlay
Classification:	Unclassified
Component:	API
Version:	unspecified
Platform:	PC Windows XP

Importance:	P1 normal (vote)
Target Milestone:	7.5.0
Assigned To:	Wadzinski Tom

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-09-25 04:26 UTC by Richard Titmuss
Modified:	2010-04-08 17:24 UTC (History)
CC List:	2 users (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Richard Titmuss 2009-09-25 04:26:14 UTC

Some sections of the code are now dependant on the player model, for example:

   System:getMachine() ~= "jive"

This is not scalable as we add more products to the platform. Please define methods to check for features in System, for example:

   System:hasPowerButton()

Each platform should then configure the system properties correctly when they start.

Comment 1 SVN Bot 2009-10-20 11:26:53 UTC

 == Auto-comment from SVN commit #7910 to the jive repo by tom ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7910 ==

Fixed Bug: 14269 +4
Description:
- Introduce system capabilities.

Comment 2 SVN Bot 2009-10-20 12:56:16 UTC

 == Auto-comment from SVN commit #7912 to the jive repo by tom ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7912 ==

Fixed Bug: 14269
Description:
- bad delete on volumeKnob

Comment 3 Chris Owens 2010-04-08 17:24:43 UTC

This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!