Bug 14252 - Setup Receiver (menu item) not working properly
: Setup Receiver (menu item) not working properly
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: SqueezeNetwork
: unspecified
: PC Windows XP
: P1 normal (vote)
: 7.4.0
Assigned To: Felix Mueller
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-24 14:06 UTC by James Richardson
Modified: 2010-02-08 09:57 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Richardson 2009-09-24 14:06:17 UTC
Selecting the 'Setup Receiver' menu item on SBC with 7.4r7745 does not do anything.  It won't go right or bump.

Expected behavior is the menu item will list out all available devices that are currently in setup mode with in radio range. 

Steps to Repo
Load 7.4 onto SBC
Factory Reset
Walk through setup wizard
After attaching to SN and associating the contrller with an account; get to Choose Player Menu
Select Set Up Receiver> (no icon)
Comment 1 James Richardson 2009-09-24 14:10:12 UTC
NOTE: Players in setup mode are properly shown in the menu above this item.

We could just remove this menu item as it appears redundant.
Comment 2 Felix Mueller 2009-09-25 04:45:14 UTC
This menu item was added to fix bug 6130. It's meant to be there to have at least one menu item in case no SBRs are detected yet.

The following patch fixes it:

Index: SelectPlayerApplet.lua
===================================================================
--- SelectPlayerApplet.lua	(revision 7746)
+++ SelectPlayerApplet.lua	(working copy)
@@ -379,7 +379,7 @@
 			text = self:string("SQUEEZEBOX_SETUP"),
 			sound = "WINDOWSHOW",
 			callback = function()
-				appletManager:callService("setupSqueezeboxSettingsShow", self.setupNext)
+				appletManager:callService("setupSqueezeboxShow", self.setupNext)
 			end,
 			iconStyle = 'receiver',
 			style = 'item',
Comment 3 Richard Titmuss 2009-09-25 06:15:52 UTC
felix, patch looks good. please commit.
Comment 4 SVN Bot 2009-09-25 06:25:48 UTC
 == Auto-comment from SVN commit #7748 to the jive repo by felix ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7748 ==

Bug: 14252 
Description: Fix 'Setup Receiver' menu item.
Comment 5 Felix Mueller 2009-09-25 06:27:47 UTC
Fixed in r7748.
Comment 6 James Richardson 2009-10-05 14:36:10 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 7 Chris Owens 2010-02-08 09:57:02 UTC
These are all bugs that have been marked 'fixed' or 'closed' but still have the bug_meeting keyword.  They were not showing up in James's bug meeting search.

Please let me know (chris_owens@logitech.com) if these need to be brought up at the next bug meeting.  In the meantime I will fix the search.