Bugzilla – Bug 14222
Undefind preset should not push into Now Playing or Current Playlist
Last modified: 2009-10-13 14:41:55 UTC
There's no reason to leave where the user was in the menu system if they press, either purposely or accidentally, a preset on the front panel or IR remote.
If you are in a menu structure, IR > Music > bla > bla or, if you are at Home; then press the preset button, it jumps you to NP Ben: yours to address?
Possibly mine, but let's cc: Tom for good measure
Looking at it again... you don't really lose your place in the menus. Pressing left-arrow returns you. But I don't see any reason to push into NP unless you're actually going to play something.
(In reply to comment #0) > There's no reason to leave where the user was in the menu system if they press, > either purposely or accidentally, a preset on the front panel or IR remote. This should read: "if they press an _undefined_ preset".
Tom and I discussed this one, which is a really needed fix but much trickier than it seems. Proposal is to send a block of data in the playerstatus message that tells SP which presets are defined, and use that to trigger a bump on any that are not defined when pressed.
Created attachment 6070 [details] send table of which presets are defined in playerstatus message to SP This is the server-side part of the fix
Created attachment 6071 [details] trap preset keys hit on undefined presets bump instead of go to now playing when an known undefined preset is hit this is the SP side of the fix
this bug fix is ready to go pending review, so I'm bumping it up to 7.4.1. assigning to Tom to begin with, but probably would be a good idea to ping Michael on the SC-side.
I have reviewed. Only one point, which doesn't affect the code- Consider removing the TODO comment at 1807 to avoid a merge issue, since the comment referred to something that has been fixed right at that line.
== Auto-comment from SVN commit #28821 to the slim repo by bklaas == == https://svn.slimdevices.com/slim?view=revision&revision=28821 == Bug: 14222 Description: send an array of which presets are defined from the server side
== Auto-comment from SVN commit #7843 to the jive repo by bklaas == == https://svn.slimdevices.com/jive?view=revision&revision=7843 == Fixed Bug: 14222 Fixed Bug: 14604 Description: make sure that data.count is type(number) bump when hitting an undefined preset key
Verified fixed in 7.4.1 r28825 // SP r7847 It appears to be working for me, Jim can you verify that the behavior is OK for you?
Yep, looks good.