Bug 14172 - This sequence causes problems
: This sequence causes problems
Status: VERIFIED FIXED
Product: SB Radio
Classification: Unclassified
Component: Power Management
: Include FW version in comment
: PC Other
: P1 normal (vote)
: 7.4.1
Assigned To: Caleb Crome
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-21 09:27 UTC by Caleb Crome
Modified: 2009-10-13 14:11 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Caleb Crome 2009-09-21 09:27:54 UTC
Power on AC & Batt.  Shut-down.  System powers up, then does not complete booting, then resets the MSP and reboots.
Comment 1 Caleb Crome 2009-09-23 13:47:15 UTC
The following patch fixes this problem.  The reason is because we can no longer measure battery voltage when the system power is off.  Thus it was getting spoofed into thinking the battery was removed.

This means we can't properly maintain RTC across battery removal, but i think that's a minor issue.  

Should we check in for 7.4.0?

Index: power.c
===================================================================
--- power.c     (revision 6428)
+++ power.c     (working copy)
@@ -265,10 +265,11 @@
                        }
                        if (!have_ac) {
                                        power_mode = POWER_OFF_BATT;
+                                       mdelay(POWER_OFF_DELAY);
                        }
-                       if (!have_batt) {
-                                       power_mode = POWER_OFF_AC;
-                       }
+                       // if (!have_batt) {
+                       //              power_mode = POWER_OFF_AC;
+                       // }
                        if (rtc_alarm_is_ringing()) {
                                        power_mode = POWER_ON_AC_AND_BATT;
                                        pins_state_on();
Comment 2 SVN Bot 2009-09-23 14:13:46 UTC
 == Auto-comment from SVN commit #6435 to the player repo by ccrome ==
 == https://svn.slimdevices.com/player?view=revision&revision=6435 ==

Fixed #14172.
Comment 3 SVN Bot 2009-09-23 14:14:52 UTC
 == Auto-comment from SVN commit #7724 to the jive repo by ccrome ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7724 ==

Fixed #14172.
Comment 4 James Richardson 2009-10-13 14:11:17 UTC
Verified fixed in SP r7847