Bug 1417 - Podcast plugin forgets added feed
: Podcast plugin forgets added feed
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Plugin
: 6.1.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Dave Cohen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-04-22 06:57 UTC by sbjaerum
Modified: 2008-08-18 10:54 UTC (History)
0 users

See Also:
Category: ---


Attachments
unified diff (533 bytes, patch)
2005-04-22 16:08 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description sbjaerum 2005-04-22 06:57:14 UTC
I have added the following feed to the Podcast plugin:
http://feeds.feedburner.com/UntouchedBeta

Occasionally this feed disappears from the Podcast feed list, and I have to
re-enter it. The feed disappears both from the server web interface and from the
SB interface. When it disappears from the user interfaces, I have confirmed that
it also has been removed from the slimserver.pref file.

I found this sequence causing the feed to disappear:

1. Stop slimserver. The feed is present in slimserver.pref after slimserver is
stopped.
2. Start slimserver. Feed is still present in slimserver.pref.
3. Go to Server Settings -> Plugins in web interface. The feed has now disappeared.

This is reproducible on my system.
I am running svn version 3028 on WinXP, and have a SB1.
There are no error messages when the feed disappears.

I don't know if it is a clue, but the feed contains an accented character in the
title:
NRK Ur�rt - Ny norsk musikk

By the way, when the feed is present on my SB, it works perfectly...
Comment 1 Vidur Apparao 2005-04-22 12:01:17 UTC
Please try setting Server Settings > Performance > Prefs write interval to 0
before quitting SlimServer. I'm guessing that your prefs aren't getting
correctly written. I'm tempted to default this value to 0 anyway, since it's
leading to confusion and attempts to solve what I don't perceive as a
performance problem.
Comment 2 KDF 2005-04-22 12:24:30 UTC
if the feed is listed in teh prefs file after the server is stopped, I think
that should be indicative of a correctly written prefs file (though I do agree
that the prefs write interval is confusing, and have set to zero a long time ago
for myself)

adding a debug line to confirm, looks like revertToDefaults() at line 50 is
being executed on startup, even if there are @feedURLPrefs.
Comment 3 KDF 2005-04-22 12:37:05 UTC
aha...think I have it.   initPlugin checks against the pref:
plugin_podcast_feeds_version, but revertToDefaults sets teh pref:
plugin_podcast_version instead.

changing line 79 to the following, fixes the problem (after one final reset, of
course):

Slim::Utils::Prefs::set('plugin_podcast_feeds_version', FEEDS_VERSION);
Comment 4 KDF 2005-04-22 16:08:11 UTC
Created attachment 449 [details]
unified diff

unified diff of my previous comment.
Comment 5 KDF 2005-04-22 20:10:10 UTC
committed in change 3046.  should be fixed now, but will require one final case
of reverting to the defaults. reopen if there is further trouble.
Comment 6 Chris Owens 2008-03-11 11:28:10 UTC
This bug was marked resolved in Slimserver 6.1, which is several versions ago.  If you're still seeing this bug, please re-open it.  Thanks!