Bug 14144 - '$query 'playlist insert' command does not work to do a play next on a rhapsody/napster album
: '$query 'playlist insert' command does not work to do a play next on a rhapso...
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: SB Server
: unspecified
: PC Other
: P1 major (vote)
: 7.4.0
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-18 22:58 UTC by Ben Klaas
Modified: 2009-10-05 14:30 UTC (History)
0 users

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2009-09-18 22:58:20 UTC
the CM for XML browse items works in all spots except "Play Next" in a rhapsody/napster album context.

See FIXME comment below...

     if ( @urls ) {

                                        if ( main::INFOLOG && $log->is_info ) {
                                                $log->info(sprintf("Playing/adding all items:\n%s", join("\n", @urls)));
                                        }

                                        if ( $method =~ /play|load/i ) {
                                                $client->execute([ 'playlist', 'clear' ]);
                                        }

                                        my $cmd;
                                        if ($method =~ /add/) {
                                                $cmd = 'addtracks';
                                        # FIXME: insert command does not work for adding an album next (insertracks also does not work here)
                                        } elsif ($method eq 'insert') {
                                                $cmd = 'insert';
                                        # inserttracks will play
                                        } else {
                                                $cmd = 'inserttracks';
                                        }

                                        my $play_index = $request->getParam('play_index') || 0;

                                        $client->execute([ 'playlist', $cmd, 'listref', \@urls ]);

                                        # if we're adding or inserting, show a showBriefly
                                        if ( $method =~ /add/ || $method eq 'insert' ) {
                                                my $icon = $request->getParam('icon');
                                                my $title = $request->getParam('favorites_title');
                                                _addingToPlaylist($client, $method, $title, $icon);
                                        # if not, we jump to the correct track in the list
                                        } else {
                                                $client->execute([ 'playlist', 'jump', $play_index ]);
                                        }
                                }
Comment 1 SVN Bot 2009-09-22 18:25:50 UTC
 == Auto-comment from SVN commit #28604 to the slim repo by andy ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28604 ==

Fixed bug 14144, use inserttracks instead of insert when inserting multiple items
Comment 2 James Richardson 2009-10-05 14:30:25 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.