Bugzilla – Bug 14122
Need placeholder to fill artwork space while loading artwork
Last modified: 2010-09-13 12:01:46 UTC
The current way a menu containing artwork is rendered is a bit jarring, text is left-aligned and then the artwork appears and pushes the text to the right. I think it would look nicer if the artwork area was populated by a placeholder item (something like an empty dashed box) while the art was being loaded, thus not causing the text to suddenly move.
This apparently works for local content and the home menu, but not for remote icons.
I'm confused about what's being described. The behavior I've seen is that a partially-transparent rounded box appears to fill the gap, which is fine...
Yeah we already have an icon, we just need to fix it so it's used for remote items i.e. Rhapsody albums.
7.4.x milestone is in the past
Created attachment 6875 [details] server-side patch to sent home_menu window style for menus that contain icons the home_menu window style is used in squeezeplay for windows that contain icons on the left side of the menu but are otherwise styled like any plain text_list menu without icons. Currently that window style is used for the home menus only (hence the style name), but this can be extended to any XMLBrowse item that contains thumbnails. there is a client-side part of this fix, but this patch does not cause UI breakage in its absence.
Created attachment 6876 [details] client-side patch to tweak misc skins to style correctly for expanded home_menu style with loading icons this patch will allow for the "loading" icons that are used in the home menus to be extended to other XMLBrowse content, e.g. Staff Picks, Internet Radio submenus, napster albums, etc.
Created attachment 6877 [details] updated client-side patch with small fix for WQVGA skin
== Auto-comment from SVN commit #30880 to the slim repo by bklaas == == http://svn.slimdevices.com/slim?view=revision&revision=30880 == Bug: 14122 Description: if XMLBrowse feed menu items have images (thumbnails) in them, use window style 'home_menu' home_menu window style is the same as text_list but puts in a placeholder icon for items with no thumbnail
== Auto-comment from SVN commit #30884 to the slim repo by bklaas == == http://svn.slimdevices.com/slim?view=revision&revision=30884 == Bug: 14122 Description: fix bad if clause in previous checkin
== Auto-comment from SVN commit #8858 to the jive repo by bklaas == == http://svn.slimdevices.com/jive?view=revision&revision=8858 == Fixed Bug: 14122 along with server side checkin r30884 or later, XMLBrowse menus that have thumbnails for any/all items will now have the window style of 'home_menu', which will put a placeholder icon by default into place on the menu item before the thumbnail loads
Works, looks good.
This bug has now been fixed in a released version of the Squeezeplay firmware (SB Touch, SB Radio, and SB Controller). If you are still seeing this bug, please make certain you are running firmware 9009 or higher, and re-open it. Thanks!
Since these are fixed, they must not be patch_waiting after all