Bug 14093 - If changing language while scan is running, SC would fail changing the collation
: If changing language while scan is running, SC would fail changing the collation
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 7.4.0
: Macintosh All
: P1 normal (vote)
: 7.4.0
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-17 03:47 UTC by Michael Herger
Modified: 2009-10-05 14:31 UTC (History)
2 users (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Herger 2009-09-17 03:47:46 UTC
Changing the collation requires a DB lock which it can't do during the scan?

[09-09-17 11:37:16.9559] Slim::Schema::Storage::throw_exception (82) Error: DBI Exception: DBD::mysql::db do failed: Lock wait timeout exceeded; try restarting transaction
[09-09-17 11:37:16.9566] Slim::Schema::Storage::throw_exception (82) Backtrace:

   frame 0: Slim::Utils::Log::logBacktrace (/Users/mh/Documents/workspace/7.4/server/Slim/Schema/Storage.pm line 82)
   frame 1: Slim::Schema::Storage::throw_exception (/Users/mh/Documents/workspace/7.4/server/CPAN/DBIx/Class/Storage/DBI.pm line 957)
   frame 2: DBIx::Class::Storage::DBI::__ANON__ (/Users/mh/Documents/workspace/7.4/server/Slim/Utils/MySQLHelper.pm line 339)
   frame 3: (eval) (/Users/mh/Documents/workspace/7.4/server/Slim/Utils/MySQLHelper.pm line 339)
   frame 4: Slim::Utils::MySQLHelper::changeCollation (/Users/mh/Documents/workspace/7.4/server/Slim/Schema.pm line 536)
   frame 5: Slim::Schema::changeCollation (/Users/mh/Documents/workspace/7.4/server/Slim/Web/Settings/Server/Basic.pm line 105)
   frame 6: Slim::Web::Settings::Server::Basic::handler (/Users/mh/Documents/workspace/7.4/server/Slim/Web/HTTP.pm line 1107)
   frame 7: Slim::Web::HTTP::generateHTTPResponse (/Users/mh/Documents/workspace/7.4/server/Slim/Web/HTTP.pm line 913)
   frame 8: Slim::Web::HTTP::processURL (/Users/mh/Documents/workspace/7.4/server/Slim/Web/HTTP.pm line 724)
   frame 9: Slim::Web::HTTP::processHTTP (/Users/mh/Documents/workspace/7.4/server/Slim/Networking/IO/Select.pm line 133)
   frame 10: (eval) (/Users/mh/Documents/workspace/7.4/server/Slim/Networking/IO/Select.pm line 119)
   frame 11: Slim::Networking::IO::Select::__ANON__ (/Users/mh/Documents/workspace/7.4/server/Slim/Networking/IO/Select.pm line 177)
   frame 12: (eval) (/Users/mh/Documents/workspace/7.4/server/Slim/Networking/IO/Select.pm line 177)
   frame 13: Slim::Networking::IO::Select::loop (slimserver.pl line 620)
   frame 14: main::idle (slimserver.pl line 574)
   frame 15: main::main (slimserver.pl line 1103)


Should we cancel the scan and restart after this action? Or at least only change the collation if the new language needs a different collation the the current language?
Comment 1 SVN Bot 2009-09-17 03:56:51 UTC
 == Auto-comment from SVN commit #28548 to the slim repo by michael ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28548 ==

Bug: 14093
Description: only change the collation when really needed
Comment 2 Michael Herger 2009-09-17 11:29:31 UTC
This can still lock up SC when changing to a language requiring a collation change
Comment 3 SVN Bot 2009-09-17 11:30:48 UTC
 == Auto-comment from SVN commit #28553 to the slim repo by michael ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28553 ==

Fixed Bug: 14093
Description: run collation change at the end of the scan if needed. Language change will change collation immediately unless a scan is running.
Comment 4 James Richardson 2009-10-05 14:31:09 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.