Bug 14056 - getModel() returns incorrect value on Fab4 and Baby
: getModel() returns incorrect value on Fab4 and Baby
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: API
: unspecified
: PC Other
: P1 normal (vote)
: 7.4.0
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-15 09:47 UTC by Felix Mueller
Modified: 2009-10-05 14:31 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Mueller 2009-09-15 09:47:22 UTC
Doing a getModel() on a local player on Fab4 or Baby returns 'controller' when connected to SN.

If connected to SC getModel() correctly returns 'fab4' or 'baby'.
Comment 1 Andy Grundman 2009-09-15 09:50:50 UTC
That's an SP method right?
Comment 2 Wadzinski Tom 2009-09-15 11:53:37 UTC
(In reply to comment #1)
> That's an SP method right?
Yes. Generally SP gets it from server status. I did a test on desktop to see what SN is sending back on it's serverstatus:
    { --[[table: 0x162a5720]]
      uuid = "0333befe7a09e5674decd6521d66a1df",
      isplayer = 1,
      displaytype = "graphic-320x32",
      ip = "71.195.51.91",
      name = "Squeezebox Toucha",
      model = "controller",
      power = "1",
      connected = 1,
      playerid = "00:04:20:22:01:0b",
    },
    { --[[table: 0x162a5740]]
      uuid = "26577041704a1861484a805bdec0415e",
      isplayer = 1,
      displaytype = "graphic-320x32",
      ip = "71.195.51.91",
      name = "Squeezebox Radio",
      model = "controller",
      power = "1",
      connected = 1,
      playerid = "00:04:20:26:01:50",
    },

Is showing "controller" for baby and touch.

I confirmed baby is sending "baby" as the model in the slimproto heloPacket:
20090915 13:49:49.012 ERROR  net.slimproto - SlimProto.lua:342 model: baby

Andy, your move.
Comment 3 Andy Grundman 2009-09-15 12:03:05 UTC
OK, and SN is using the slimproto deviceid to determine the model (always 9 for these).  I need to update this code to use the model value.
Comment 4 SVN Bot 2009-09-15 12:03:54 UTC
 == Auto-comment from SVN commit #7344 to the network repo by andy ==
 == https://svn.slimdevices.com/network?view=revision&revision=7344 ==

Fixed bug 14056, use model value in serverstatus when available
Comment 5 James Richardson 2009-10-05 14:31:12 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.