Bug 14048 - Napster Artist Albums returns Function call
: Napster Artist Albums returns Function call
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Browser
: unspecified
: PC Windows XP
: P1 normal (vote)
: 7.4.0
Assigned To: James Richardson
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-15 08:14 UTC by James Richardson
Modified: 2009-10-05 14:37 UTC (History)
3 users (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Richardson 2009-09-15 08:14:28 UTC
Doing an On Napster search while playing artist Sia, then selecting Artist Albums will return a Function: 0x507f90 = EMPTY on SP devices.

This happens while connected to SBS or SN
Comment 1 Andy Grundman 2009-09-15 10:32:23 UTC
This is a larger bug, that any empty list renders wrong in SP due to a JSON 
decoding bug.  Can we fix this so an empty list is displayed properly on the SP 
side, rather than having to code a special "Empty" item on the SN side?
Comment 2 Ben Klaas 2009-09-15 12:43:48 UTC
I believe we've attempted some kind of fix for this before and come up with nothing. Passing to Richard for comment.
Comment 3 SVN Bot 2009-09-17 03:56:14 UTC
 == Auto-comment from SVN commit #7634 to the jive repo by richard ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7634 ==

Bug #14048
Changed json.null to a userdata with a meta table. Now when null data is received 'null' will be displayed on 
the UI instead of a function pointer. This still should be handled correctly by the application layer. Tested 
with the json parser test suite.
Comment 4 Richard Titmuss 2009-09-17 03:59:07 UTC
I've changed the implementation of json.null to use a userdata+metatable instead of a function pointer. This will mean if this value is displayed in the ui 'null' will be used instead.

Where relevant SlimBrowser should be handling this, by comparing to json.null and using a localized empty string.

Searching for Sia albums on Napster is returning several albums for me, so I can't find where this is being rendered incorrectly. Look for 'null' in the latest firmware.
Comment 5 James Richardson 2009-09-17 10:30:57 UTC
This looks like it's fixed now, with your latest change.  I tried several different artists and can not replicate the issue now.
Comment 6 James Richardson 2009-09-17 10:33:01 UTC
For those artists with no albums, I see the 'empty' tag now instead of the function tag
Comment 7 James Richardson 2009-10-05 14:37:19 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.