Bug 14047 - Battery-only Baby goes into OFF immediately after being left OFF overnight
: Battery-only Baby goes into OFF immediately after being left OFF overnight
Status: CLOSED FIXED
Product: SB Radio
Classification: Unclassified
Component: Power Management
: Include FW version in comment
: PC Windows XP
: P1 normal (vote)
: 7.4.0
Assigned To: Wadzinski Tom
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-15 08:08 UTC by Mickey Gee
Modified: 2009-10-05 14:28 UTC (History)
5 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mickey Gee 2009-09-15 08:08:43 UTC
With Baby firmware r7566, I turned off my battery-only Baby with the short power OFF. I then left it that way overnight.

In the morning, I pressed the short power ON. I saw the Logitech logo, Free Your Music, and then blank screen.

Since my OFF screen saver was a blank screen, I thought the unit might have returned to its OFF state. I pressed the Power button quickly, and the home menu appeared.

It looks like after a self-imposed long power OFF, the unit goes back to its previous state -- the short power OFF. I would like it to go straight to ON.
Comment 1 Mickey Gee 2009-09-15 08:10:53 UTC
Of course, it's a PVT Baby!
Comment 2 Caleb Crome 2009-09-15 09:32:13 UTC
Ah, yes, that makes sense.

I believe this is an app issue, not an MSP issue.

Let's define a couple terms:

ON:  Well, well we all know what ON is
OFF:  The system is on, but the user sees 'off'
SHUTDOWN:  The system is in shutdown state, and must reboot upon power up.

I believe the situation Mickey is describing is this:

ON -> (power press) -> OFF -> (timeout) -> SHUTDOWN -> (power press) -> (boot) -> OFF.

This, as mickey suggests, is incorrect.  It should go to ON state, not OFF state.
Comment 3 Wadzinski Tom 2009-09-15 10:02:09 UTC
When doing the local power control, i made it so that the soft power state is preserved at startup time. However, in most cases, it seems it should just come up with soft power ON. However, if the device was in soft power OFF and baby crashed, just as the startup sound doesn't occur, it should also not switch to soft power ON, I would think. All the hooks are there in the code to do this easily with the following logic: 
if savedSoftPowerState is OFF and was not clean shutdown then
  setSoftPower("off")
else
 setSoftPower("on")
end

On a crash, there would still be a brief flash showing the "Free your music" screen, then it would go to the "when off" screensaver (normally screen off)

Sound good?

Alternatively, I can just always set it on on startup, and during crashes it would just always come on,m just like any other startup.
 
Either way, the server would likely have the player power state as off, but with the new local control syncing, the player state would update the server state, correcting it, so that's covered.
Comment 4 Pat Ransil 2009-09-15 19:46:53 UTC
Tom - I like the logic you have there. When SoftPowerOff=True and user presses Power, turn on. If SoftPowerOff=True and crash, come back to SoftPowerOff=True.

Also, if SoftPowerOff=True and there is a power failure (and no battery), when power comes back, come back to SoftPowerOff=True.
Comment 5 SVN Bot 2009-09-16 14:17:53 UTC
 == Auto-comment from SVN commit #7623 to the jive repo by tom ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7623 ==

Bug: 14047 +2
-  only power up in soft power off if last reboot was unclean and saved soft power state was "off"
Comment 6 James Richardson 2009-10-05 14:28:21 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.