Bug 14006 - Volume control numbers as ##.909090909091
: Volume control numbers as ##.909090909091
Status: CLOSED FIXED
Product: SB Radio
Classification: Unclassified
Component: Menus
: Include FW version in comment
: PC Windows XP
: P1 major (vote)
: 7.4.0
Assigned To: Wadzinski Tom
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-12 21:51 UTC by Arthur Tham
Modified: 2010-05-27 14:45 UTC (History)
2 users (show)

See Also:
Category: Bug


Attachments
Volume control numbers as ##.909090909091 (332.95 KB, application/x-zip-compressed)
2009-09-12 21:51 UTC, Arthur Tham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Arthur Tham 2009-09-12 21:51:17 UTC
Created attachment 5838 [details]
Volume control numbers as ##.909090909091

When adjusting the volume, the numbers appear as ##.909090909091
(40.909090909091, 41.909090909091, 42.909090909091, etc). See pictures in
attachment.

Also, between each click of the volume control, the audio is muted as the
volume numbers increase/decrease.

I am unable to reproduce this bug, since it only happens sometimes. I believe
the bug disappeared when I pushed the Volume button in for mute.

This happened with previous firmware too, but my Baby Boom is now running
7.4.0-r7526. This is a propudction hardware revision 2 unit.
Comment 1 James Richardson 2009-09-13 09:09:01 UTC
Tom: is this yours to address?  QA has not seen this before, is there anything in the code that could cause this to appear?
Comment 2 Ben Klaas 2009-09-13 09:09:39 UTC
Tom, guessing this is an artifact of local volume control changes. A suggested patch:

=== Volume.lua
==================================================================
--- Volume.lua  (revision 36042)
+++ Volume.lua  (local)
@@ -55,7 +55,8 @@
                self.slider:setValue(0)
 
        else
-               self.title:setValue(tostring(self:_getVolume()) )
+               local intVolume = math.floor(self:_getVolume())
+               self.title:setValue(tostring(intVolume))
                self.icon:setStyle('icon_popup_volume')
                self.slider:setValue(self:_getVolume())
        end
Comment 3 SVN Bot 2009-09-14 07:14:36 UTC
 == Auto-comment from SVN commit #7552 to the jive repo by tom ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7552 ==

Fixed Bug: 14006
- don't deal in fractional volumes
Comment 4 SVN Bot 2009-09-14 08:01:27 UTC
 == Auto-comment from SVN commit #7554 to the jive repo by tom ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7554 ==

Fixed Bug: 14006
- too easy to break through barrier, made "push" time longer
Comment 5 James Richardson 2009-10-05 14:34:58 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 6 Chris Owens 2010-05-27 14:45:38 UTC
These bugs have all been marked resolved and belong to a component which is being removed.  Therefore they have been moved to the most applicable of the new components.