Bug 13969 - Context Menus are absent in many XMLBrowse items
: Context Menus are absent in many XMLBrowse items
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: SB Server
: unspecified
: PC Other
: P1 normal (vote)
: 7.4.0
Assigned To: Ben Klaas
:
Depends on: 13462
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-11 07:42 UTC by Ben Klaas
Modified: 2009-10-05 14:30 UTC (History)
4 users (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2009-09-11 07:42:05 UTC
e.g.

Rhapsody->My Library->Artists->Some Artist
Napster->My Napster Library->Artists->Some Artist
Comment 1 Andy Grundman 2009-09-11 07:52:12 UTC
I don't really understand, what would be in the context menu for these items?
Comment 2 Ben Klaas 2009-09-11 08:08:03 UTC
In local music browsing

My Music->Artists->Some Artist

yields a context menu with things like "Play", "Play Next", "On Foo", etc.

is this not applicable or not possible with XMLBrowse items such as the ones described?

I suppose this may close with a WONTFIX, but it seems wrong to me.
Comment 3 Andy Grundman 2009-09-11 08:21:52 UTC
It's not really possible.  I suppose you could create a generic context menu for items that have 2 paths, i.e. a play URL and a regular navigation URL, offering play/add/favorites/etc.  This is a bit related to that other bug about touch to play.

In my mind, it all comes back to the lack of a visual indicator that something is playable (or that something has a context menu).  We really need those. :(
Comment 4 Ben Klaas 2009-09-11 08:30:29 UTC
Yes, agree that it's related...I'm just going to link this one to that one then and leave this one open.
Comment 5 Joerg Schwieder 2009-09-11 09:54:58 UTC
It should definitely have at least "play", "add" and "insert" where applicable, shouldn't it?

BTW, this was already an issue with the old XMLBrowser implementation that there really was no way to find out whether an item is playable or not.
Comment 6 Andy Grundman 2009-09-11 09:56:29 UTC
It is definitely possible to find out whether something is playable (ip3k UI shows a music note icon), the problem is what to do with this info.  I sound like a broken record, the SP UI needs the same music note icon!  Been saying this for years.
Comment 7 Weldon Matt 2009-09-15 19:06:46 UTC
(Note to self and others: main problem here, I think, is the lack of a spec?)

First, it would be nice to have a full list of where CMs currently DO exist.  I have no way to test the current implementation fully without this... maybe starting a wiki page would be helpful.

as per the bug, yes, Rhapsody items should have context menus just the same as local music.

In local music, an artist has the CM items "add to end, play next, play, save to favorites."  It seems reasonable to also have these items for Rhapsody artists.

Having said all this, it probably makes sense (either inside or outside the context of this bug) to sit back and fully map out long-term plans for CMs, including auditing the content and order of menu items (as suggested by Noah in another bug), and fully defining all the spots where CMs need to be, for an 8.0 release.

I've always envisioned that practically ALL items would have some sort of context menu (anything playable should be add-able to favorites, and pretty much any navigation option could have an "add/remove from home screen" option... is this insanity?)

Andy, I'm chewing on your request about music notes on playable items.  We'll probably end up doing something, need to think about it a bit more and discuss with Noah.
Comment 8 Andy Grundman 2009-09-15 19:11:02 UTC
Rhapsody *artists*??  Absolutely not.
Comment 9 Ben Klaas 2009-09-15 19:48:18 UTC
For 7.4 the pseudo-spec I've been going with is this: 

if you can hit play and something comes out the speakers, it should have a context menu. That context menu should be reasonably consistent, at least with respect to having some common playlist control items in them: e.g., play, play next, add to end. This, after all, is what you'd typically want to do with a playable item, play it or get it ready to play.

Rhapsody artists aren't currently playable anyway, so they don't get context menus.

Let's forget that CMs should be available for all items, because in terms of 7.4 release that's not going to happen. But is what's described above, consisent CMs for playable items, a) acceptable (Weldon?) and b) doable (Andy?).
Comment 10 Ben Klaas 2009-09-18 23:00:24 UTC
this is as done as its going to be for 7.4. Playable XMLBrowse items have CMs that list Add to End, Play Next, and Play (only).

Opening a separate bug for an enhanced CM for XML browse items, as this is the bare minimum of what's acceptable.
Comment 11 James Richardson 2009-10-05 14:30:41 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.