Bug 1396 - Missing line of pixels
: Missing line of pixels
Status: RESOLVED WORKSFORME
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 6.0.0
: PC Debian Linux
: P2 normal (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-04-19 05:53 UTC by Philip Downer
Modified: 2009-09-08 09:11 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Downer 2005-04-19 05:53:47 UTC
When the Bump-Up or Bump-Down method is called, a line of pixels is missed off
from the top/bottom of the text. This can be seen with a plugin that displays
the bumped up/down text for longer than usual i.e. the example Hello World
plugin, although it is possible to spot it during normal usage.

I have 2 Squeezboxes, one has the older display and does not have this bug. The
second has the newer display and does have the bug. I do not have any Squeeze
Box 2 to test them.

This bug appears was present in 6.0 and is still present in the 19 April Nightly
build.
Comment 1 Philip Downer 2005-04-20 06:17:50 UTC
My SB2 just arrived in the mail and that has a different response to the bump-up
or bump-down... To start with, it's a lot faster as in the old SB would bump the
text up and wait a short while, this does not in fact holding the up arrow in a
Hello World plugin produces a flickering effect. Also when the text dissappears
off the screen, about a quarted of the characters are still shown, to this end I
think it is perhaps a design feature but just inconsistent across the model range.
Comment 2 KDF 2005-06-16 00:20:55 UTC
there are bound to be inconsistencies becuase the client side animation for
bumpUp and bumpDown is not possible on anything but an SB2. So the rest are
faked in the best way that the hardware will allow.  The 'flicker' is a timer
overlap with the repeat and is unavoidable without creating a special case for
holding up/down.

I have no idea where this 'quarter of the characters' is.  I can't see it.  The
line left over is something I do see and is either a feature to avoid completely
losing the line off the screen or needs adjusting for the shift of the graphics.
in SqueezeboxG::bumpUp() and bumpDown()
Comment 3 KDF 2005-06-16 00:42:20 UTC
seems to be mostly due to the offset nature of the medium font on the SBG. 
small doesn't seem to suffer.  Large/Huge show half as expected.

flicker may be somewhat exacerbated by the occasional missed repeat trapping, as
per bug 1573
Comment 4 Adrian Smith 2005-07-01 09:41:04 UTC
I think this is a feature not a bug!

bumpUp/Down on SBG simply moves the display up by 8 bits.  The display is 16 
bits high.  So if the fonts for line 1 and line 2 are equal then you see just 
one line of text.  If the fonts are different heights then you see the effect 
you notice.

For SB2, the display is 32 bits high and the firmware in the player currently 
moves the display up/down by 8 bits [1/4 of display height].  It could be 
argued that SB2 should only bumpUp the second line (as only the second line 
scrolls.)  But this would be an enhancement for the firmware.

Agree with the missed repeat trapping - this makes bumpUp/Down look odd when 
it occurs.
Comment 5 Blackketter Dean 2005-09-16 16:05:56 UTC
Ah, this is working as designed.  The bump-up/down is half a screen worth, independent of the font 
sizes (on Squeezebox1).