Bug 13931 - Context menu callback commands broken for local music throughout Squeezeplay
: Context menu callback commands broken for local music throughout Squeezeplay
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: SB Server
: unspecified
: PC Other
: P1 major (vote)
: 7.4.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-09 15:03 UTC by Ben Klaas
Modified: 2009-10-05 14:29 UTC (History)
3 users (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2009-09-09 15:03:26 UTC
the wrong callbacks are being attached to CM items. This is a fresh break as this was known to work very recently.

Likely a server-side issue, hunch is XMLBrowser
Comment 1 Ben Klaas 2009-09-09 15:11:30 UTC
here's the issue-- base actions are correct, but item_loop is sending callbacks now too and that's stomping on base.

do {
  my $a = [
    {
      channel => "/08e4513c/slim/request",
      data => {
            base      => {
                           actions => {
                                 add => {
                                       cmd => ["albuminfo", "playlist", "add"],
                                       itemsParams => "params",
                                       params => { menu => "albuminfo" },
                                       player => 0,
                                     },
                                 "add-hold" => {
                                       cmd => ["albuminfo", "playlist", "insert"],
                                       itemsParams => "params",
                                       params => 'fix',
                                       player => 0,
                                     },
                                 go => { cmd => ["albuminfo", "items"], itemsParams => "params", params => 'fix' },
                                 more => {
                                       cmd => ["albuminfo", "items"],
                                       itemsParams => "params",
                                       params => 'fix',
                                       player => 0,
                                       window => { isContextMenu => 1 },
                                     },
                                 play => {
                                       cmd => ["albuminfo", "playlist", "play"],
                                       itemsParams => "params",
                                       nextWindow => "nowPlaying",
                                       params => 'fix',
                                       player => 0,
                                     },
                                 "set-preset-0" => {
                                       cmd => ["jivefavorites", "set_preset", "key:0"],
                                       itemsParams => "params",
                                       player => 0,
                                     },
                                 "set-preset-1" => {
                                       cmd => ["jivefavorites", "set_preset", "key:1"],
                                       itemsParams => "params",
                                       player => 0,
                                     },
                                 "set-preset-2" => {
                                       cmd => ["jivefavorites", "set_preset", "key:2"],
                                       itemsParams => "params",
                                       player => 0,
                                     },
                                 "set-preset-3" => {
                                       cmd => ["jivefavorites", "set_preset", "key:3"],
                                       itemsParams => "params",
                                       player => 0,
                                     },
                                 "set-preset-4" => {
                                       cmd => ["jivefavorites", "set_preset", "key:4"],
                                       itemsParams => "params",
                                       player => 0,
                                     },
                                 "set-preset-5" => {
                                       cmd => ["jivefavorites", "set_preset", "key:5"],
                                       itemsParams => "params",
                                       player => 0,
                                     },
                                 "set-preset-6" => {
                                       cmd => ["jivefavorites", "set_preset", "key:6"],
                                       itemsParams => "params",
                                       player => 0,
                                     },
                                 "set-preset-7" => {
                                       cmd => ["jivefavorites", "set_preset", "key:7"],
                                       itemsParams => "params",
                                       player => 0,
                                     },
                                 "set-preset-8" => {
                                       cmd => ["jivefavorites", "set_preset", "key:8"],
                                       itemsParams => "params",
                                       player => 0,
                                     },
                                 "set-preset-9" => {
                                       cmd => ["jivefavorites", "set_preset", "key:9"],
                                       itemsParams => "params",
                                       player => 0,
                                     },
                               },
                         },
            count     => 4,
            item_loop => [
                           {
                             actions => {
                                   add => { cmd => ["albuminfo", "items"], params => { menu => "albuminfo" } },
                                   go  => { cmd => ["albuminfo", "items"], params => 'fix' },
                                 },
                             addAction => "go",
                             text => "Add to End",
                           },
                           {
                             actions => {
                                   add => { cmd => ["albuminfo", "items"], params => { menu => "albuminfo" } },
                                   go  => { cmd => ["albuminfo", "items"], params => 'fix' },
                                 },
                             addAction => "go",
                             text => "Play Next",
                           },
                           {
                             actions => {
                                   add => { cmd => ["albuminfo", "items"], params => { menu => "albuminfo" } },
                                   go  => { cmd => ["albuminfo", "items"], params => 'fix' },
                                 },
                             addAction => "go",
                             text => "Play",
                           },
                           {
                             actions => {
                                   add => { cmd => ["albuminfo", "items"], params => { menu => "albuminfo" } },
                                   go  => { cmd => ["albuminfo", "items"], params => 'fix' },
                                 },
                             addAction => "go",
                             text => "Delete Favorite",
                           },
                         ],
            offset    => 0,
            title     => "Abductions and Reconstructions",
            window    => { windowStyle => "text_list" },
          },
      ext => { priority => "" },
      id => 11,
    },
  ];
Comment 2 SVN Bot 2009-09-09 20:12:59 UTC
 == Auto-comment from SVN commit #28485 to the slim repo by bklaas ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28485 ==

Fixed Bug: 13931
Description: don't stomp on item params after $item->jive stuff already in response
Comment 3 James Richardson 2009-10-05 14:29:38 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.