Bug 13928 - Disable charging when volume > 90
: Disable charging when volume > 90
Status: RESOLVED WONTFIX
Product: SB Radio
Classification: Unclassified
Component: Power Management
: Include FW version in comment
: PC Other
: P2 normal (vote)
: 7.4.0
Assigned To: Caleb Crome
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-09 11:31 UTC by Caleb Crome
Modified: 2009-10-14 09:03 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Caleb Crome 2009-09-09 11:31:16 UTC
Disable charging when volume > 90

This is done by

echo 1 > /sys/bus/i2c/devices/1-0010/battery_disable

re-enable by 

echo 0 > /sys/bus/i2c/devices/1-0010/battery_disable
Comment 1 Pat Ransil 2009-09-09 15:47:45 UTC
Check with Tom re line-in
Comment 2 Ben Klaas 2009-09-10 07:34:43 UTC
assigning to Richard, who needs to discuss further with Caleb.
Comment 3 Richard Titmuss 2009-09-10 12:11:08 UTC
I had a discussion with Caleb (see below). This may not be needed, and if it is probably it'll be best to monitor this in the DSP.

(6:03:13 PM) richard: turning off the battery charging at high volumes - would that be something the dsp can monitor and do?
(6:03:28 PM) caleb: sure
(6:04:18 PM) caleb: Funny thing is that we don't realloy need to do it at all.
(6:04:38 PM) caleb: if the PSU shuts down... no big deal, it'll power back up in a second :-)
(6:05:13 PM) caleb: Actually, I wasn't able to get it to shut down at all, even at full volume.
(6:05:26 PM) caleb: So maybe not an issue.
(6:11:52 PM) richard: ok, so should we not do it then? one less thing?
(6:12:00 PM) caleb: hmmmm
(6:12:22 PM) caleb: it's going over the limit of the PSU a bit, so I'm not sure it won't shut down in the field.
(6:12:29 PM) caleb: I'd prefer to put something in.
(6:13:00 PM) richard: k, if you add the code to detect it in the dsp, i can add in the code to write to /sys easily.
(6:13:23 PM) caleb: but.... OTOH, I haven't seen it shut down the PSU, and even if it does, the music will keep playing.
(6:13:53 PM) caleb: Problem is that the message will need to get to the MCU pretty quickly.
(6:14:17 PM) caleb: but, probably a few ms is fine.
Comment 4 Caleb Crome 2009-09-15 20:31:48 UTC
Making a P2 for PLD.  My measurements showed that the current limiter is good enough to prevent shutdown, even if the battery is charging.
Comment 5 Caleb Crome 2009-10-14 09:03:43 UTC
This does not appear to be necessary.  Will reopen if it becomes an issue.