Bug 13896 - Inconsistent use of the 'play' button (FW7433)
: Inconsistent use of the 'play' button (FW7433)
Status: RESOLVED INVALID
Product: SB Controller
Classification: Unclassified
Component: UI
: unspecified
: PC Windows Vista
: P3 normal (vote)
: 7.4.0
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-07 16:17 UTC by Stefan Hansel
Modified: 2009-09-09 18:39 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Hansel 2009-09-07 16:17:50 UTC
pressing 'play' on internetradio makes this start instantly.
pressing 'play' on an album gets the song-list of the album
pressing 'play' on a song just adds it to the playlist

This is heavily inconsistent, I'd prefer 'play' to always start the selected item instantly (or as a/my second choice always put it in the playlist).

Maybe it should be even a setting, how wants the 'play'-button to be used ('instant play' vs. 'put into playlist')
Comment 1 Ben Klaas 2009-09-08 08:37:15 UTC
Stefan, can you update your SqueezeCenter (which is now called Squeezebox Server)

This works according to design for me:

pressying play on internet radio makes this start instantly
pressing play on an album plays the album instantly
pressing play on a song loads the entire tracklist from the album to the playlist and play starts on that song immediately

can you update your server and confirm this is what you see as well? If not, it could be a server pref that you have set differently, and would like to get to the bottom of that.
Comment 2 Stefan Hansel 2009-09-08 12:18:34 UTC
Updated the server to the latest version (Version: 7.4 - r28455 @ Mon Sep 7 04:02:38 PDT 2009), updated firmware on controller (now FW7443). 

I realize that your described behaviour is indeed true, when I select Squeezebox-Receiver as player.

When I select the Controller as player, than we have the inconsistent behaviour from above.

I'm really surprised - didn't expect that the logic could be different for different players.
Comment 3 Stefan Hansel 2009-09-08 12:19:18 UTC
*** Bug 13897 has been marked as a duplicate of this bug. ***
Comment 4 Ben Klaas 2009-09-08 12:25:15 UTC
Yes, it's the same code, so if it works differently on controller something else is at play.

Is your controller pointed to a different server or SqueezeNetwork instead of your local server?

I just tested with the controller and it worked as designed for me...

Any chance you have playlist mode or party mode enabled for the controller under Settings->Advanced->Beta Features?
Comment 5 Stefan Hansel 2009-09-08 12:32:28 UTC
Dammit - yes !

So as a conclusion I'd suggest to insert at least 'Party-Mode' in the popups.
This is really confusing, if someone played with the controller without your knowing (have to talk to my wife now :) )

Furthermore in party-mode pressing 'play' on internet-radio maybe should put it into playlist as well ?
Comment 6 Ben Klaas 2009-09-08 12:40:29 UTC
Sorry about that-- what's happened basically is the big changes in 7.4 (press-to-play, context menus) have trumped playlist/party mode, and not enough attention has been given to how they should behave under playlist/party mode.

Further, playlist/party mode is probably going to be stripped out in favor of a better solution, which is documented in bug 13689.

I think what I'm going to do for 7.4 release is hide the playlist mode feature from the Beta menu and on the server side explicitly ignore whatever the playlist mode is set to and just have it be efffectively "off".

This won't be pleasing to those that championed the Party Mode bug in the first place, but it doesn't make sense to have this admittedly half done feature breaking other behavior.
Comment 7 SVN Bot 2009-09-08 13:52:29 UTC
 == Auto-comment from SVN commit #28473 to the slim repo by bklaas ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28473 ==

Bug: 13896
Bug: 13689
Bug: 8878
Description:  playlist/party mode, a feature that was never fully baked/completed, is in direct conflict with some of the touch-to-play behavior introduced in 7.4. I'm dealing with this issue by removing the Settings->Advanced->Beta Features->Playlist Mode item and explicitly ignoring whatever client pref is set for playlistMode and always returning 'off'. This effectively kills the partial fix for bug 8878, but I believe if we can concentrate on what is laid out in 13689 we may have a better solution.

Voters of bug 8878, I feel your pain. If I had a party I wouldn't hand the controller to anyone for fear of killing the music/destroying the playlist. It stinks, and I will do my best to continue to raise this issue for a better and more full solution.
Comment 8 Philip Meyer 2009-09-09 16:44:02 UTC
Shouldn't it return "disabled" as the setting, rather than "off"?  I thought in "off" mode, adding a song to the current playlist changed to playlist mode.

I don't want anything to do with playlist mode, and now I can't disable it?
Comment 9 Ben Klaas 2009-09-09 18:39:00 UTC
Phil, just consider the feature dead and gone.