Bug 1384 - Duplicate artist entry when name contains accented character
: Duplicate artist entry when name contains accented character
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 6.1.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-04-15 11:51 UTC by sbjaerum
Modified: 2008-09-15 14:37 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Flac file with embedded cuesheet causing duplicate album entry (2.36 MB, application/octet-stream)
2005-04-15 11:57 UTC, sbjaerum
Details
proposed fix (432 bytes, patch)
2005-04-15 16:14 UTC, Vidur Apparao
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description sbjaerum 2005-04-15 11:51:04 UTC
I have a FLAC file with embedded cuesheet and tag information on the
numbered vorbis comment format. The artist name is H�sker D�.
When Browsing Artist, this album occurs twice. One correct listing, and one
listing with empty album.

Having only this file in my Music Folder, slimserver displays:
Your music library contains 1 album with 20 songs by 2 artists

I have no problems with albums by artists without accented characters.

I am using latest nightly (SlimServer_v2005-04-15) on WinXP.
Comment 1 sbjaerum 2005-04-15 11:57:10 UTC
Created attachment 428 [details]
Flac file with embedded cuesheet causing duplicate album entry

I hope the reported error is reproducible with the attached Flac file.
The file contains only 22 seconds of music, but it contains cuesheet and tag
information corresponding to the entire album.
Comment 2 Dan Sully 2005-04-15 12:12:59 UTC
Michael - is this really a cue sheet issue?
Comment 3 sbjaerum 2005-04-15 14:22:13 UTC
I have experienced the error and tried to make it reproducable.
I am not an expert on this, so I don't want to speculate whether the problem is
with the cuesheet functionality or if the problem is somewhere else in the server.
Please let me know how I can contribute in fixing the bug.
Comment 4 michael 2005-04-15 16:14:12 UTC
yeah, this was a flac/cuesheet issue.  some code paths were getting utf-8
decoding more often than others.  I pushed the utf-8 decoding up into
Parse::readCUE and FLAC::getTag(), which seems to have helped.
revision 2984 should work better with the attached example.
Comment 5 Vidur Apparao 2005-04-15 16:14:55 UTC
Created attachment 429 [details]
proposed fix

Yes, it's a cuesheet issue. We were marking FLAC tags as UTF-8, but not those
for embedded cuesheet tracks. The attached patch fixes that.
Comment 6 sbjaerum 2005-04-16 10:29:18 UTC
I downloaded latest versions of Parse.pm and FLAC.pm from SVN repository.
I can confirm that with these patches the problem has been solved.
Well done!
Comment 7 KDF 2005-04-16 14:11:16 UTC
thanks for the confirmation :)
Comment 8 Chris Owens 2006-06-16 14:41:11 UTC
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.