Bug 13837 - In store demo does not survive a power cycle with 7.4 firmware
: In store demo does not survive a power cycle with 7.4 firmware
Status: CLOSED FIXED
Product: SB Radio
Classification: Unclassified
Component: Settings
: Include FW version in comment
: PC Windows XP
: P1 major (vote)
: 7.4.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-03 11:53 UTC by Spies Steven
Modified: 2009-10-05 14:35 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Spies Steven 2009-09-03 11:53:26 UTC
This is with the latest 7.4 firmware which is r7398 at the moment.

Same behavior as bug 12612 except this is against 7.4 not MP.
Comment 1 Ben Klaas 2009-09-05 08:46:44 UTC
Richard, leaving this assigned to me right now, but is there any reason to think that the file sync issue fixed in 12612 is back?
Comment 2 Richard Titmuss 2009-09-08 13:28:27 UTC
Ben, no. I can look at this if you like.
Comment 3 Ben Klaas 2009-09-08 13:31:50 UTC
I'll triage it first to determine if the issue is in the settings file not surviving reboot, then will push your way if needed, but with more info.
Comment 4 Ben Klaas 2009-09-08 19:01:58 UTC
Demo file is there, but it's not triggering the applet to start automatically on reboot. Richard, I'm going to keep this bug in my court and fix it tomorrow first thing.

# cat /etc/squeezeplay/userpath/settings/Demo.lua 
settings = {volumeSetting=51,startDemo=true,}
Comment 5 Ben Klaas 2009-09-08 20:56:26 UTC
Demo applet requires local player before auto-starting demo. This used to work but now does not. It appears iteratePlayers isn't populated at the time DemoMeta.lua runs configureApplet(). My guess this is a bad consequence of some changes that have been made elsewhere with player registration

function configureApplet(meta)
        local localPlayer = nil
        for mac, player in appletManager:callService("iteratePlayers") do
                if player:isLocal() then
                        localPlayer = player
                        break
                end
        end

        if not localPlayer then
                return
        end

        if meta:getSettings()['startDemo'] then
                local demo = appletManager:loadApplet('Demo')
                demo:startDemo()
        end

end
Comment 6 SVN Bot 2009-09-08 20:58:22 UTC
 == Auto-comment from SVN commit #7466 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7466 ==

Fixed Bug: 13837
Description: give Demo a loadPriority of 1000 so it's the last applet loaded, so localPlayer is available.
Comment 7 Ben Klaas 2009-09-08 21:00:42 UTC
Actually, I'm going to reopen this for comment and push it Tom's way.

Tom, do you know if localPlayer is available on a controller after boot (i.e., after applets have loaded)? I think the Meta logic in comment#5 is flawed for Controller demo if that's the case...
Comment 8 Wadzinski Tom 2009-09-10 11:43:23 UTC
Ben, on a factory reset controller, playback is, as of a week ago or so, turned off, so the Demo Applet will fail..
Comment 9 SVN Bot 2009-09-11 20:50:56 UTC
 == Auto-comment from SVN commit #7537 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7537 ==

Fixed Bug: 13837
Description: remove requirement in meta file for localPlayer to be available. The applet will not fail if localPlayer isn't there, it just won't play a tune. This is good, since controller and fab4 demos will not have sound.

Baby demo should still fire up with sound because its late load priority will mean that localPlayer will be there
Comment 10 Ben Klaas 2009-09-12 08:57:39 UTC
QA- I was not able to adequately test this bug on my last checkin, so give this fix extra scrutiny.
Comment 11 James Richardson 2009-10-05 14:35:14 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.