Bug 13796 – Menu templates - bottom menu bar not aligned properly at end of list

Bug 13796 - Menu templates - bottom menu bar not aligned properly at end of list

Summary:

Menu templates - bottom menu bar not aligned properly at end of list

Status:	CLOSED FIXED

Product:	SB Controller
Classification:	Unclassified
Component:	UI Skin
Version:	unspecified
Platform:	Other Other

Importance:	P1 normal (vote)
Target Milestone:	7.4.0
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-08-31 19:25 UTC by ndijulio
Modified:	2009-10-05 14:35 UTC (History)
CC List:	2 users (show)

See Also:
Category:	Bug

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description ndijulio 2009-08-31 19:25:30 UTC

A 2-3px gap is seen when the last item in a menu is selected.  Menu bar should butt up against top of status bar.

Comment 1 Ben Klaas 2009-08-31 22:37:46 UTC

Noah, can you comment on this?

Landscape: 36 title bar + 4*45px menu + 24 px statusbar = 240px
Portrait: 36 title bar + 6*43px menu + 24 px statusbar = 318px

Portrait falls 2px short...how would you like me to fix? add a px to title and status bar?

Comment 2 ndijulio 2009-09-01 09:34:18 UTC

Portrait: *37px* tb + *1px* shadow line + 6*43px menu + 24px statusbar = 320px

The difference is 1px is added to the titlebar.png + 1 px titlebar_shadow.png. Factor those in and we should be good.

Comment 3 ndijulio 2009-09-04 14:34:50 UTC

Ben- reassigning to you for implementation...

Comment 4 Ben Klaas 2009-09-04 14:48:47 UTC

Noah, just for clarity-- in the skin code the 1px for the shadow line is counted as part of the title height.

So, title = 38px is all I need to know :)

Comment 5 SVN Bot 2009-09-05 08:44:05 UTC

 == Auto-comment from SVN commit #7426 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7426 ==

Fixed Bug: 13796
Description: 38px high titlebar, 38px of top border on menu for QVGAportrait

Comment 6 James Richardson 2009-10-05 14:35:32 UTC

This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.