Bugzilla – Bug 1373
blank entry in music folder (was: slimserver crashes - Can't call method "titlesort" on an undefined value)
Last modified: 2008-08-18 10:54:16 UTC
using a recent svn checkout (revision 2958 at the moment) slimser is playing along and then suddenly crashes. The console message says: Can't call method "titlesort" on an undefined value at /usr/src/slim/server/Slim/Music/Info.pm line 1061 --d_info doesn't reveal anything more useful.
d_sql, d_files maybe you could also add this before the return at 1060: unless ($obj) { print "object not found for $item\n"; Slim::Utils::Misc::bt(); }
oh...apparently this bug was mentioned in teh comments for bug1329. Vidur just committed a fix at r2959 that fixes this crash.
reopening this. The change in 2959 certainly keeps it from crashing, but there's still an underlying cause that needs to be pinned down, at least for this code path. updating summary to reflect new behaviour. So, here's what I've tracked down so far... If you have "Sort By File Name" set to "Sort by song information" and you Browse Music Folder to a directory that contains an external cuesheet, then getInfoForSort() gets an incorrect value from isList(). Before revision 2959, this would cause a crash. After 2959, it displays a blank entry (no title/link, just buttons) where the cuesheet file should be listed. The lack of a title suggests that perhaps objectForUrl() isn't returning an object in this case. Then, if you leave it running for awhile, it'll "fix" itself. But don't worry, if it does this all you have to do is wipe cache to get back to the bug behaviour described here.
seems that new folders also cause this blank entry in Browse Music Folder. This is relatively new, since this used to work fine.
Could be related to my posting to http://forums.slimdevices.com/showthread.php?t=13622.
Vidur - I think I saw a checkin from you to fix this?
Actually, r2987 from Michael should have fixed this. Michael, can you confirm?
The crash or blank line issue specifically mentioned is fixed, and the remaining problems seem to be captured by other bug entries, so I guess this can be closed. Outstanding issues worth noting, sorting is all wrong (see bug 1360) and fixing this seems to have reverted my partial fix for bug 720.
This bug was marked resolved in Slimserver 6.1, which is several versions ago. If you're still seeing this bug, please re-open it. Thanks!