Bugzilla – Bug 1370
removing Now Playing from player menu creates weird behavior
Last modified: 2008-09-15 14:37:04 UTC
if you remove now playing from the main player menu then: - press now playing - press left to go to main menu - Squeezebox Home 'Browse Music' is displayed. press right and it goes in to Now Playing, not Browse Music.
dan, got a patch to fix this, will attach in a sec...
Created attachment 425 [details] default to first item for home menu instead of falling to NOW_PLAYING on the home menu, we should default to item 0 in the list. This will then be the top item shown in the player settings->menus
Looks good.
fix merged to trunk r2961, 6_0_X branch r2962
darn, seems that change 3082 DOES break this fix after all :( calling jump('NOW_PLAYING') is trouble is now playing isn't in the home menu settings.
Created attachment 479 [details] when jumping to a home item, make sure it exists I guess Dean wanted to go left from Now Playing and ensure that we get to teh now playing item in the home menu. same for search. however, when now playing isn't in the home menu, we slip to another item but still go back to now playing when moving right. This is confusing. This patch checks on a jump that the home menu item exists. if not, it then sets the home postion to the first item in the list so that when pushign right the player will go into the correct mode for that item. Please run this by Dean and see if this still fits his requirements.
sorry, guess this needs to go to vidur since this is all now wrapped around change 3082 and what the intent of that was.
Created attachment 486 [details] jump to search ok, the last patch didnt' work for search, so I've reworked the way jump() and jumpToMenu() work. jump will go to an item in teh home menu, or switch to the first item. jumpToMenu will go directly to any menu available in the home hash, which would include plugins and other submenus shoudl they ever be applicable. this properly jumps to now playing when the button is pushed, search on search button and properly pushes left from the top level.
committed to 6.1 at change 3119 committed to 6.0.3 at change 3120 please re-open if this doesn't fit Dean's requirements
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006. I am setting them to targets of 6.2.1 to keep them from showing up in my queries.