Bug 137 - Build cover art filename from ID3 tags
: Build cover art filename from ID3 tags
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: unspecified
: All All
: P2 enhancement (vote)
: ---
Assigned To: KDF
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-01-13 06:49 UTC by Johan Franz�n
Modified: 2008-09-15 14:37 UTC (History)
0 users

See Also:
Category: ---


Attachments
Patch to improve variable cover art. (905 bytes, patch)
2004-01-14 13:40 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Franz�n 2004-01-13 06:49:48 UTC
All my cover art images are named ARTIST - ALBUM.jpg.
It would be cute if SlimServer could use them.
Comment 1 KDF 2004-01-13 14:09:47 UTC
use %ARTIST - ALBUM.jpg in the sever settings for interface, cover art.
also works for thumb art.

I plan to expand this later, but it was just simplest to do the above and
leverage the titleformat subroutines.  the % at the start is the flag to trigger
this format.  Sadly, its one or the other for now. titleformat style OR raw
filename.

Comment 2 Johan Franz�n 2004-01-14 06:42:52 UTC
Hm, I can't get this to work. I've enabled debugging for d_info and read the
/log.txt. No matter what I enter for the Cover Art Title Format, SlimServer
always tries to load a .jpg named as the track's title, i.e. it uses the
'default argument' of 
	$cover = infoFormat($file, $1, "TITLE").".jpg";

So, %ARTIST - ALBUM doesn't work for me, am I doing something wrong?
Comment 3 KDF 2004-01-14 13:40:16 UTC
Created attachment 5 [details]
Patch to improve variable cover art.


This fixes the problem.  Cover art setting can use any item typically used in
TitleFormat.  Start with % and end with the file suffix (default .jpg)

ie:

%ARTIST - ALBUM
will add a check for "U2 - Joshua Tree.jpg" when looking for covers on any
songs
on U2's Joshua Tree album.

%ARTIST - ALBUM.gif will look for "U2 - Joshua Tree.gif", etc

patch included.

-kdf
Comment 4 KDF 2004-01-14 23:22:32 UTC
now fixed in CVS.  should hit a nightly build Jan 15 or 16.
Comment 5 Chris Owens 2006-06-16 14:42:12 UTC
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.