Bug 13676 - Playing goes into Current Playlist when playlist is empty
: Playing goes into Current Playlist when playlist is empty
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: UI
: unspecified
: PC Windows XP
: P1 normal (vote)
: 7.4.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-25 14:51 UTC by Jim McAtee
Modified: 2009-10-05 14:28 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2009-08-25 14:51:37 UTC
When the current playlist is empty, playing anything (tested with My Music, internet radio and Pandora) takes you to the Current Playlist screen instead of into Now Playing.  When the playlist contains at least one item, it correctly brings up Now Playing.
Comment 1 James Richardson 2009-08-25 15:12:09 UTC
Weldon: what is the proper behavior in these 2 cases? should it take you to Now Playing or Current Playlist?
Comment 2 Weldon Matt 2009-08-25 15:27:24 UTC
Jim, trying to understand your use case here?

If the current playlist is empty, then selecting something to "play" adds it to the playlist, right? (Therefore the current playlist will no longer be empty)?

Having said that, the correct behavior is to ALWAYS take the user to the now playing screen when they play something "new".

2 NOTABLE exceptions:

- the user is viewing the "current playlist" 
- the user is "unpausing" something that is currently paused.
Comment 3 Jim McAtee 2009-08-25 15:39:30 UTC
(In reply to comment #2)
> Jim, trying to understand your use case here?
> 
> If the current playlist is empty, then selecting something to "play" adds it to
> the playlist, right? (Therefore the current playlist will no longer be empty)?

Correct.


This should be very easy to reproduce:

1. Clear the playlist.

2. Browse My Music, play something.  You're taken to the Current Playlist.

3. Browse My Music again, play something.  You're taken to Now Playing.
Comment 4 Weldon Matt 2009-08-25 20:12:29 UTC
Thanks Jim.

Yup, def. a bug.  Please see comment 2 for correct/desired behavior...
Comment 5 SVN Bot 2009-08-26 09:36:09 UTC
 == Auto-comment from SVN commit #7268 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7268 ==

Fixed Bug: 13676
Description: have NP delay 1 second when new playerstatus hasn't returned yet and check again for playlist_tracks > 0 before punting to the playlist window
Comment 6 Jim McAtee 2009-08-26 09:42:32 UTC
Obviously I haven't seen this change yet, but why "punt" to the Current Playlist?  Now Playing should be viewable when the playlist is empty.
Comment 7 Ben Klaas 2009-08-26 09:56:13 UTC
The window handling an empty playlist needs to be managed by SlimBrowser, not NowPlaying. That's the current playlist window, and it displays a special case when the playlist is empty.
Comment 8 James Richardson 2009-10-05 14:28:40 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.