Bug 13619 – Another tweak for _getCDDBTags parsing in FLAC.pm

Bug 13619 - Another tweak for _getCDDBTags parsing in FLAC.pm

Summary:

Another tweak for _getCDDBTags parsing in FLAC.pm

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Tagging
Version:	7.3.4
Platform:	PC Ubuntu Linux

Importance:	-- normal (vote)
Target Milestone:	7.4.0
Assigned To:	Andy Grundman

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-08-23 21:55 UTC by Manoj Kasichainula
Modified:	2009-10-05 14:35 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Patch for tag-parsing (394 bytes, patch) 2009-08-23 21:56 UTC, Manoj Kasichainula	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Manoj Kasichainula 2009-08-23 21:55:38 UTC

I submitted one patch last year to tighten parsing of cddb-style tags for flacs w/ embedded cuesheets. Later I found that the regex failed on a various-artists album where one of the artists is a single-letter name. I'll attach a small patch I've been running with for a while which fixes this.

Though it probably doesn't matter:

squeezecenter from "testing" apt repo (7.3.4~28180) on Ubuntu Jaunty.

Comment 1 Manoj Kasichainula 2009-08-23 21:56:13 UTC

Created attachment 5668 [details]
Patch for tag-parsing

Comment 2 Andy Grundman 2009-08-24 06:38:19 UTC

Thanks, applied in 7.4.

Comment 3 SVN Bot 2009-08-24 06:39:13 UTC

 == Auto-comment from SVN commit #28253 to the slim repo by andy ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28253 ==

Fixed bug 13619, patch from Manoj to FLAC CDDB tag parsing

Comment 4 James Richardson 2009-10-05 14:35:58 UTC

This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.