Bugzilla – Bug 13617
Menus contain erroneous "add" command in 7.4
Last modified: 2010-01-06 06:21:09 UTC
This one is pretty critical for me to make iPeng work with SqueezeNetwork in 7.4 since otherwise there will be no shortcut to use the "add" functionality and always having to go through the context menu while building playlists will certainly generate user resistance. Currently, the "add" command is broken in the menus sent by the server. I do understand that SP is no longer using the "add" command but replacing the functionality of the button with "more", yet the command should still be correct. There is one in the "base" fields and a different one in the item actions. Wouldn't it be possible to send the context menu as a "more" action? I use it in iPeng to add a track and while "play" and "insert" still work, add does not. Here's an example from a Napster album (there's more broken than just the "add" command, btw, there's also an empty item in there again. What's wrong, as far as I can see: - The "base" command has a correct command for "add" but the parameters are wrong - The item action has a trackinfo menu command yet the parameters are wrong in that the url does not match the id. The url is the one for the currently playing track and not the one for the item. It's also the same for all items. do { my $a = [ { channel => "/aecaa6d2/slim/request", data => { base => { actions => { add => { cmd => ["trackinfo", "playlist", "add"], itemsParams => "params", params => { item_id => "93edcdbf.3", menu => "trackinfo", url => "napster://track:15584846.wma", }, player => 0, }, "add-hold" => { cmd => ["trackinfo", "playlist", "insert"], itemsParams => "params", params => 'fix', player => 0, }, go => { cmd => ["trackinfo", "items"], itemsParams => "params", params => 'fix' }, play => { cmd => ["trackinfo", "playlist", "play"], itemsParams => "params", params => 'fix', player => 0, }, ... preset commands removed ... }, }, count => 14, item_loop => [ ... Play All and Add To PL removed ... { actions => { add => { cmd => ["trackinfo", "items"], itemsParams => "params", params => { favorites_title => "More More More von Kylie Minogue aus Fever", favorites_url => "napster://track:15584845.wma", item_id => "93edcdbf.3.1", menu => "trackinfo", type => "link", url => "napster://track:15584846.wma", }, }, "add-hold" => { cmd => ["trackinfo", "playlist", "insert"], itemsParams => "params", params => { favorites_title => "More More More von Kylie Minogue aus Fever", favorites_url => "napster://track:15584845.wma", item_id => "93edcdbf.3.1", type => "link", }, player => 0, }, go => { cmd => ["trackinfo", "playlist", "play"], itemsParams => "params", nextWindow => "nowPlaying", params => 'fix', player => 0, }, more => 'fix', }, addAction => "more", params => 'fix', playAction => "go", style => "itemplay", text => "More More More von Kylie Minogue aus Fever", }, ... more of the same removed ... { actions => { add => { cmd => ["trackinfo", "items"], params => { item_id => "93edcdbf.3.13", menu => "trackinfo", url => "napster://track:15584846.wma", }, }, go => { cmd => ["trackinfo", "items"], params => 'fix' }, play => { cmd => ["trackinfo", "items"], params => 'fix' }, }, addAction => "go", playAction => "go", text => undef, }, ], offset => 0, title => "Fever", window => { windowStyle => "text_list" }, }, ext => { priority => "" }, id => 52, }, ];
Ben, I'm seeing a lot of broken menus like that, especially th URL seem to be very often wrong. How is this whole thing supposed to be? Should I specify what I'd like :-)
== Auto-comment from SVN commit #7250 to the jive repo by bklaas == == https://svn.slimdevices.com/jive?view=revision&revision=7250 == Bug: 13617 Description: map add-hold action to the 'add' command from SC
== Auto-comment from SVN commit #28257 to the slim repo by bklaas == == https://svn.slimdevices.com/slim?view=revision&revision=28257 == Bug: 13617 Description: make more an explicit item sent to SP, leave add in its previous-to-CM form XMLBrowser probably still needs some work to support the add-hold = add next case, but it fully works in local music SP r7250 is good to update to with this checkin, as we're now mapping the add-hold action to the add command from SC
Pippin- a checkin on the SC side may have things cleared up for you, r28257. I'm now sending the CM command callback as the 'more' item and (I hope) the add command should come through untouched now. XMLBrowser items may need some work. Can you check out both local SC items and things from Napster et al. and let me know how this works for you?
this is an administrative shuffle on priority fields to help make better judgment on the top end of the priority list. P4->P5, P3->P4, and P2->P3.
Ok, looks good for local files. Could not check for remote files since SN doesn't work right now, will do as soon as https://bugs-archive.lyrion.org/show_bug.cgi?id=13738 is fixed.
OK, tested Napster, too, and that looks less good. The command is OK, but the barams are wrong: actions => { add => { cmd => ["trackinfo", "playlist", "add"], itemsParams => "params", params => { favorites_title => "Advertising Space von Robbie Williams aus Intensive Care", favorites_url => "napster://track:15906678.wma", isContextMenu => 1, item_id => "10996c8d.2.0.29", type => "link", }, player => 0, }, "add-hold" => { cmd => ["trackinfo", "playlist", "insert"], itemsParams => "params", params => 'fix', player => 0, }, go => { cmd => ["trackinfo", "playlist", "play"], itemsParams => "params", nextWindow => "nowPlaying", params => 'fix', player => 0, }, more => { cmd => ["trackinfo", "items"], itemsParams => "params", params => { favorites_title => "Advertising Space von Robbie Williams aus Intensive Care", favorites_url => "napster://track:15906678.wma", isContextMenu => 1, item_id => "10996c8d.2.0.29", menu => "trackinfo", type => "link", url => "napster://track:28914217.wma", }, }, }, params => 'fix', playAction => "go", style => "itemplay", text => "Advertising Space von Robbie Williams aus Intensive Care",
Jörg - is this still an issue? Sounds related to what I've been working on earlier today.
I believe this is something else and has been fixed by Ben before the 7.4 launch. In this bug the issue was, that the context menu was being delivered in the "add" action, not, as it is now, in a separate "more" action. This was causing trouble when iPeng used the "add" action to add items to the Playlist. My last comment from Aug. 31 may be related to what we were talking about this afternoon.
Thanks for the feedback. Let's consider this fixed then.