Bug 13487 - Don't display overlays when an action moves into Now Playing
: Don't display overlays when an action moves into Now Playing
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: UI
: unspecified
: PC Windows XP
: P3 normal (vote)
: 7.5.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-19 12:49 UTC by Jim McAtee
Modified: 2010-04-08 17:24 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2009-08-19 12:49:02 UTC
Is this related to bug 12876?  Maybe these popups are called "show brieflies".  The main situation where I see them are when playing from a context menu.

Any time some action such as Play moves directly into Now Playing, do not show the overlay.  It's unnecessary for user feedback and only serves to obscure (and delay) the Now Playing screen.
Comment 1 Weldon Matt 2009-08-19 13:47:37 UTC
Exactly right.  This is spec-ced but it wasn't described this plainly.
Comment 2 Ben Klaas 2009-08-27 22:10:46 UTC
Tom, I'm assigning this over to you but want to discuss it with you. I'm not entirely sure this is fixable at all given the granularity we have on Framework:isMostRecentInput(). I also noticed that the method often returns incorrect information.

added this debug:
           local usingTouch = Framework:isMostRecentInput('mouse')
                local usingIR = Framework:isMostRecentInput('ir')
                local usingKey = Framework:isMostRecentInput('key')

log:warn('touch:', usingTouch)
log:warn('IR:  ', usingIR)
log:warn('Key: ', usingKey)

this was after hitting pause on IR remote or hitting a key on the player:
20090828 05:04:39.119 WARN   squeezebox.player - Player.lua:1261 touch:true
20090828 05:04:39.119 WARN   squeezebox.player - Player.lua:1262 IR:  false
20090828 05:04:39.119 WARN   squeezebox.player - Player.lua:1263 Key: false

There's a second layer here that the showBriefly from the server is not directly coupled with the window transition to Now Playing so it's not possible to specify these specific showBrieflies to be suppressed.
Comment 3 SVN Bot 2009-08-31 12:38:03 UTC
 == Auto-comment from SVN commit #7341 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7341 ==

Fixed Bug: 13487
Description: changed logic to suppress icon-based showBriefly from SC for everything except IR
Comment 4 Jim McAtee 2009-09-29 20:06:16 UTC
Reopening this bug. I still see this behavior on Radio when browsing the Music Folder and pressing Play on a folder.
Comment 5 SVN Bot 2010-02-18 13:50:40 UTC
 == Auto-comment from SVN commit #30209 to the  repo by bklaas ==
 == https://svn.slimdevices.com/?view=revision&revision=30209 ==

Fixed Bug: 13487
Description: don't display "Now Playing..." popup since we are pushing into Now Playing window now
Continue to show showBrieflies for Add-to-next and Add-to-end in this context
Comment 6 Jim McAtee 2010-03-03 16:52:52 UTC
At r8617 I still see the overlay on Touch when using the IR to play a selection.  I'm talking about the rounded-corner box with a right-pointing solid triangle ("Play") icon that appears.  I can't tell from the above discussion whether or not it's been decided to keep this behavior for IR control.
Comment 7 Ben Klaas 2010-03-03 18:32:33 UTC
That is correct behavior with the IR remote
Comment 8 Chris Owens 2010-04-08 17:24:33 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!