Bugzilla – Bug 1348
moved plugins need to clean up old ones.
Last modified: 2008-08-18 10:54:16 UTC
ShoutcastBrowser, RadioIO, and Picks have all been moved to PluginName/Plugin.pm structure instead of the older PluginName.pm form in order to add web interfaces. On upgraded installs, this leaves the older forms around as working plugins as well. we need a new method to clean up the old plugins. One option would be to have the server keep a list and delete those. Another more scalable option would be a destroyPlugin() function that can be called from a plugin to remove an old version. this way, only the plugin authors have to keep track of old versions and can be done when the plugins are installed instead of having to wait for a slimserver release/build. I'm still very busy with the day job, so it will be a while. I'd be more than happy to take ideas and mini-patches/test feedback along the way.
Oops... sorry, should have read this report before answering on the mailing list :-/. But do we really need that method? RPMs could take care of the problem (I guess) as does the Windows installer. This should cover most of the users. Those using tarballs and zip files should be able to fix the problem themselves. Well, at least for the main plugins contained in the distribution. I'm not sure third part plugin authors would care too much about doing and testing one more procedure in their plugins. I only recently came across the possibility of the initPlugin() (was it?) and others...
well, there was one other option I had: make you do it ;) doing it in teh builds/installers means coming up with 3 different versions, plus testing, and answering 3 different sets of pissing and moaning if it fails. Those who use svn or tarballs have proven themselves to be not as self-sufficient as I would have once hoped. I think it would be unwise to simply expect them all to be perfectly capable and willing to deal wth the confusion. it also doesn't solve the problem if third party plugins start doing the same moves.
the windows installer needs to remove these. needed for 6.1. Mac is ok, since the plugins in the package are completely wiped out. The RPM appears to do the right thing already, removing the old .pm files. Windows need to selectively remove the old versions.
*** Bug 1512 has been marked as a duplicate of this bug. ***
this is starting to get reported more and more since 6.0.x is becoming stagnant in favour of moving toward 6.1. This problem needs a fix. if it is to be the installer, then this really falls to very specific people who know best how the installer works. Need to hunt them down and make some bribes.
Fixed Windows installer to remove old Radioio.pm, Picks.pm, ShoutcastBrowser.pm and Live365.pm. Did I miss any?
This bug was marked resolved in Slimserver 6.1, which is several versions ago. If you're still seeing this bug, please re-open it. Thanks!