Bugzilla – Bug 13438
Finish context menu behavior
Last modified: 2009-10-05 14:30:00 UTC
various: - Make sure cm appears on any xmlbrowser and local music menu item - make sure CM comes up in cases like "Save to Favorites" confirm screen - Don't use item history for CM menus
== Auto-comment from SVN commit #7117 to the jive repo by tom == == https://svn.slimdevices.com/jive?view=revision&revision=7117 == Bug:13438 Description: - no use of history for CM items - Read nextWindow correctly for do actions - if CM and 'grandparent' close CM
== Auto-comment from SVN commit #7118 to the jive repo by bklaas == == https://svn.slimdevices.com/jive?view=revision&revision=7118 == Bug: 13438 Description: allow album art to show up on showBrieflies with new 'popupalbum' type ('song' is now suppressed by Tom's new rebuffering behavior, so need something that will bring up showBriefly with art)
== Auto-comment from SVN commit #28198 to the slim repo by bklaas == == https://svn.slimdevices.com/slim?view=revision&revision=28198 == Bug: 13438 Description: add "Play Next" item to CMs rework order of add/play/play next items in CM make sure CM is used for Save To Favorites menu make nextWindow params correct for Favorites adding/deleting requires squeezeplay r7117 to work as desired
== Auto-comment from SVN commit #28210 to the slim repo by bklaas == == https://svn.slimdevices.com/slim?view=revision&revision=28210 == Bug: 13438 Description: if a Slim::Menu::*Info item has isContextMenu => 1, XMLBrowser should respect that setting
== Auto-comment from SVN commit #28212 to the slim repo by bklaas == == https://svn.slimdevices.com/slim?view=revision&revision=28212 == Bug: 13438 Description: correct behavior for CM and currently playing playlist window
== Auto-comment from SVN commit #28213 to the slim repo by bklaas == == https://svn.slimdevices.com/slim?view=revision&revision=28213 == Bug: 13438 Description: use common 'playitem' for all Menu::* levels so Favorites can place itself just below it
== Auto-comment from SVN commit #28220 to the slim repo by bklaas == == https://svn.slimdevices.com/slim?view=revision&revision=28220 == Bug: 13438 Description: have Play Next in current playlist context work correctly for CM's
== Auto-comment from SVN commit #7137 to the jive repo by bklaas == == https://svn.slimdevices.com/jive?view=revision&revision=7137 == Fixed Bug: 13286 Fixed Bug: 13068 Bug: 13438 Description: fix CM on currently playing song in playlist window create new action, go_current_track_info, managed by slimbrowser that brings up trackinfo CM for currently playing track + button on Now Playing screen invokes go_current_track_info { from keyboard invokes go_current_track_info center button from single item playlist in Now Playing invokes go_current_track_info
Still not working: Pandora Genre Station items do not launch CM with + MP3Tunes does not launch CM
Still see CM problems with pandora genres and mp3tunes. Reassigning to Ben, since he's the master of this area. These might be Andy issue though. ALso, touch to play doesn't work for a pandora custom browse, probably related to bug 13685
additional debug- $base from XMLBrowser -> Squeezeplay in this return data for Pandora->Your Stations does not have a command callback for 'more'. If I put a 'more' action in base, however, the 'go' action also triggers a context menu to launch. { --[[table: 0x16dbe720]] "myapps", "items", 0, 200, "type:link", "menu:myapps", "favorites_url:http://www.test.squeezenetwork.com/api/pandora/v1/opml/stations", "item_id:11235151.4.0", "favorites_title:Your Stations", "useContextMenu:1", } { --[[table: 0x176d0960]] id = "12", ext = { --[[table: 0x17657140]] priority = "", }, data = { --[[table: 0x176d0980]] offset = "0", count = 23, title = "Your Stations", window = { --[[table: 0x1765f8e0]] windowStyle = "text_list", }, base = { --[[table: 0x176d09a0]] actions = { --[[table: 0x176d09c0]] ["set-preset-8"] = { --[[table: 0x176d0c80]] cmd = { --[[table: 0x17662b30]] "jivefavorites", "set_preset", "key:8", }, itemsParams = "params", player = 0, }, ["set-preset-2"] = { --[[table: 0x1765f700]] cmd = { --[[table: 0x1765f8c0]] "jivefavorites", "set_preset", "key:2", }, itemsParams = "params", player = 0, }, ["add-hold"] = { --[[table: 0x176d0ab0]] cmd = { --[[table: 0x176d0b10]] "myapps", "playlist", "insert", }, itemsParams = "params", player = 0, params = { --[[table: 0x176d0ad0]] menu = "myapps", }, }, ["set-preset-9"] = { --[[table: 0x1765f610]] cmd = { --[[table: 0x1765f7d0]] "jivefavorites", "set_preset", "key:9", }, itemsParams = "params", player = 0, }, ["set-preset-4"] = { --[[table: 0x176d11b0]] cmd = { --[[table: 0x1765f6e0]] "jivefavorites", "set_preset", "key:4", }, itemsParams = "params", player = 0, }, ["set-preset-3"] = { --[[table: 0x176d1110]] cmd = { --[[table: 0x176d1150]] "jivefavorites", "set_preset", "key:3", }, itemsParams = "params", player = 0, }, ["set-preset-7"] = { --[[table: 0x176d1170]] cmd = { --[[table: 0x1765f5f0]] "jivefavorites", "set_preset", "key:7", }, itemsParams = "params", player = 0, }, ["set-preset-1"] = { --[[table: 0x176d09e0]] cmd = { --[[table: 0x176d0a20]] "jivefavorites", "set_preset", "key:1", }, itemsParams = "params", player = 0, }, ["set-preset-6"] = { --[[table: 0x176d1130]] cmd = { --[[table: 0x176d1190]] "jivefavorites", "set_preset", "key:6", }, itemsParams = "params", player = 0, }, ["set-preset-0"] = { --[[table: 0x176d0a00]] cmd = { --[[table: 0x176d0bf0]] "jivefavorites", "set_preset", "key:0", }, itemsParams = "params", player = 0, }, ["set-preset-5"] = { --[[table: 0x176d0d40]] cmd = { --[[table: 0x1767e600]] "jivefavorites", "set_preset", "key:5", }, itemsParams = "params", player = 0, }, go = { --[[table: 0x176d0d60]] cmd = { --[[table: 0x176d1060]] "myapps", "items", }, itemsParams = "params", params = { --[[table: 0x1767e620]] menu = "myapps", }, }, play = { --[[table: 0x17662b10]] cmd = { --[[table: 0x1767e570]] "myapps", "playlist", "play", }, player = 0, nextWindow = "nowPlaying", itemsParams = "params", params = { --[[table: 0x1767e500]] menu = "myapps", }, }, add = { --[[table: 0x176d0d80]] cmd = { --[[table: 0x176d0c60]] "myapps", "playlist", "add", }, itemsParams = "params", player = 0, params = { --[[table: 0x176d0b30]] menu = "myapps", }, }, }, }, item_loop = { --[[table: 0x1765fa40]] { --[[table: 0x1765fa60]] text = "QuickMix", params = { --[[table: 0x1765fa80]] favorites_title = "QuickMix", favorites_url = "pandora://7498531905705254.mp3", isContextMenu = 1, item_id = "11235151.4.0.0", type = "link", }, }, (etc.)
== Auto-comment from SVN commit #28466 to the slim repo by bklaas == == https://svn.slimdevices.com/slim?view=revision&revision=28466 == Fixed Bug: 13438 Description: add a 'more' action that opens a context menu with the + key for XML browse items like Pandora stations and MP3tunes items note this does not fix the more critical problem of XMLBrowse items not behaving according to "touch/press to play" spec. That is covered by 13462 Until 13462 is fixed, this is only an incremental improvement and is not really at "release quality" behavior.
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server! * SqueezeCenter: 28672 * Squeezebox 2 and 3: 130 * Transporter: 80 * Receiver: 65 * Boom: 50 * Controller: 7790 * Radio: 7790 Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.