Bug 13390 - Need a success message after 7.4 firmware upgrade
: Need a success message after 7.4 firmware upgrade
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: UI
: unspecified
: PC Other
: P1 major (vote)
: 7.4.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-13 11:31 UTC by Weldon Matt
Modified: 2009-10-05 14:35 UTC (History)
6 users (show)

See Also:
Category: Feature


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Weldon Matt 2009-08-13 11:31:51 UTC
After users successfully upgrade to 7.4, we need to present the following success message to users (in the form of a single-option screen with supporting text):

You have just upgraded to firmware version 7.4!  This is a major upgrade and there have been many changes.  Please visit www.squeezenetwork.com for more information.

Continue ->
Comment 1 Andy Grundman 2009-08-23 10:05:00 UTC
This is probably something that should be done on the SP side.  Ben/Tom?
Comment 2 Ben Klaas 2009-08-23 13:57:47 UTC
1. Do we have strings for this?

2. Is this really necessary?

3. Do we stop shipment of 7.4 if we don't do this?
Comment 3 Ben Klaas 2009-08-24 09:11:47 UTC
Ben to add EN string today, support before 7.4 release.

I personally don't believe this to be a 7.4 P1 bug, but was overruled.
Comment 4 SVN Bot 2009-08-24 14:07:41 UTC
 == Auto-comment from SVN commit #7243 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7243 ==

Bug: 13390
Description: checkin EN string to support bug 13390
Comment 5 Jim McAtee 2009-08-24 14:40:33 UTC
This will be presented after the reboot, correct?  I'd find it a little annoying before the reboot, but fine if done after.

Please also display the new firmware version number in the message.  I'd also like to suggest that if the 'revert to previous' firmware procedure is done that this success message be displayed after the device comes back up with the new (old) firmware running.
Comment 6 Richard Titmuss 2009-09-10 08:35:04 UTC
My solution is a bit of a hack. There is a file that stores the version number /etc/squeezeos.version. This is used (by the boot scripts) to tell if the system has been upgraded. A couple of ways this could work:

1. The boot scripts leave the previous revision in /etc/squeezeos.old.version. The the lua can first check a settings flag, and the squeezeos version files to determine if the message should be shown.

-or-

2. The boot scripts touch /var/run/upgraded. This file is not persistent so will only be seen on the reboot following an upgrade (or downgrade). /etc/squeezeos.version can then be checked to see if this is now 7.4.

I prefer 2, but that works on downgrades too.

Andy, you mentioned some simple inbox you made for SC. Would it be easy to use that for SP now too?

Ben, pass the bug back to me if you'd like me to make either of those changes.
Comment 7 Andy Grundman 2009-09-10 10:59:47 UTC
I was hoping the message could be 100% SP-side because I'm not sure the inbox would work properly.  It's SN-only and this message should be shown to SC users, for example.
Comment 8 Richard Titmuss 2009-09-11 02:11:09 UTC
Ben, which of my suggestions do you prefer?
Comment 9 Ben Klaas 2009-09-11 15:40:21 UTC
of the two options, I prefer 2 over 1
Comment 10 Ben Klaas 2009-09-16 14:35:09 UTC
Richard, after further reflection am I correct in saying that solution #2 won't work because a 7.4->7.4 upgrade would also touch /var/run/upgraded, thus a check of that and looking at /etc/squeezeos.version won't be sufficient for identifying a 7.3->7.4 upgrade?
Comment 11 Ben Klaas 2009-09-16 14:36:29 UTC
after discussion with Richard suggestion 2 is not really a working one, since /var/run/upgraded would also get touched on a 7.4->7.4 update, which is not what we'd want for this.

my suggestion is to explore option 1
Comment 12 SVN Bot 2009-09-17 03:24:28 UTC
 == Auto-comment from SVN commit #7633 to the jive repo by richard ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7633 ==

Bug #13390
Added /etc/squeezeos.version.bak following an upgrade.
Comment 13 SVN Bot 2009-09-17 22:02:27 UTC
 == Auto-comment from SVN commit #7650 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7650 ==

Fixed Bug: 13390
Description: check squeezos.version.bak and squeezeos.version to see if 7.3->7.4 upgrade occurred. If so, push messaging window to screen
Comment 14 Jim McAtee 2009-09-17 22:09:59 UTC
What do you mean by a '7.3->7.4' upgrade?  Won't a message be displayed for all firmware up/down-grades?
Comment 15 James Richardson 2009-10-05 14:35:34 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.