Bug 13333 - Old artists are not removed when scan for new and changed is run
: Old artists are not removed when scan for new and changed is run
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 7.4.0
: PC Windows Home Server
: P2 normal with 2 votes (vote)
: 8.0.0
Assigned To: Andy Grundman
http://forums.slimdevices.com/showpos...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-11 10:27 UTC by Sue Chastain
Modified: 2014-08-13 04:49 UTC (History)
5 users (show)

See Also:
Category: Bug


Attachments
Screen shot (20.76 KB, image/png)
2009-08-11 10:27 UTC, Sue Chastain
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sue Chastain 2009-08-11 10:27:42 UTC
Created attachment 5596 [details]
Screen shot

When I edit some tags in my files and then do a scan for new and changed, the
new information is added to the database, but the original (bad) artist is not
removed. I had several files that were being scanned as No Artist, No Album,
and No Genre. I discovered the problem in the tags, corrected the files, then
did a scan for new and changed with SbS. Now they show up with the correct
Album and Genre, but the Artist is listed as "No Artist, Correct Artist" so it
is including the old and the new.

With SC 7.4-26558 and earlier, the old, bad information was removed in a scan
for new and changed music.

Here is another report of the same issue in the forums:
http://forums.slimdevices.com/showpost.php?p=447127&postcount=6

Version: 7.4 - r28143 @ Tue Aug 11 04:02:29 PDT 2009
Hostname: HPSERVER
IP: 192.168.2.14
HTTP Port: 9000
OS: Windows Home Server - EN - cp1252
Platform: 586
Perl Version: 5.10.0 - MSWin32-x86-multi-thread
MySQL Version: 5.0.22-community-nt
Comment 1 Ross Levine 2009-08-11 12:22:45 UTC
Are cuesheets involved at all? I'm wondering if there is any similarity to bug 10636.
Comment 2 Jim McAtee 2009-08-11 13:48:06 UTC
This is an old, old bug with new/changed scans.  Not only artists, but genres, and possibly albums.

See bug 6720.  It's the same bug with regard to the 'years' field.  And bug 8034 is also somewhat related.

The only real question is how to fix it.  Whether you update the database incrementally whenever you find a single track has changed or if you do a 'cleanup' of stale artists, genres, albums and years at the end of the scan (this was the fix for bug 6720).

My feeling is that incremental updating, although slower, is more desirable and more robust as well.  Although it's slower than running cleanup queries, changes of this nature are relatively uncommon.  Even if spelling changes were common, within the scope of a library with thousands of tracks, they're relatively few.
Comment 3 Jim McAtee 2009-08-11 13:59:21 UTC
One thing I forgot to mention is the behavior of Browse Music Folders (BMF), which performs the same tasks as a new/changed scan, but only within directories that are browsed.  BMF would benefit from the incremental database updating whenever changed tracks are encountered, since you don't have an "end of scan" when browsing the music folder.  You could run the db cleanup queries when you find a changed track (although I'll bet it's not being done currently), but then someone browses into another folder and you may have to do it all over again.  With incremental updating you'd just always run the queries to remove stale content any time you find a changed file.
Comment 4 Sue Chastain 2009-08-11 14:07:05 UTC
(In reply to comment #1)
> Are cuesheets involved at all? I'm wondering if there is any similarity to bug
> 10636.

no cuesheets here
Comment 5 Mikael Nyberg 2009-09-09 15:10:12 UTC
Yep this happend the other day edited some tags for an album that showed up 3 times, after a scan for new and changed i had 4 albums.

I did a clear and rescan this morning it solved the problem. now it is 1 album.

Flac files no cue sheets or playlists
Comment 6 Jim McAtee 2011-09-04 10:24:57 UTC
Removal of old artists by a new & changed scan works well for me in 7.6.x. Try it again and close the bug if it appears to be fixed for you.
Comment 7 Michael Herger 2014-08-13 04:49:43 UTC
Thanks Jim.