Bug 13265 – Since rename to SqueezeboxServer the init.d script can't stop server

Bug 13265 - Since rename to SqueezeboxServer the init.d script can't stop server

Summary:

Since rename to SqueezeboxServer the init.d script can't stop server

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Platform Support
Version:	7.4.0
Platform:	PC Ubuntu Linux

Importance:	P1 normal (vote)
Target Milestone:	7.4.0
Assigned To:	Matt Wise

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-08-06 07:17 UTC by radish
Modified:	2009-10-05 14:28 UTC (History)
CC List:	1 user (show)

See Also:
Category:	Bug

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description radish 2009-08-06 07:17:49 UTC

There's a typo in the init.d script for SqueezeboxServer which stops it from being able to stop the server (and hence restart causes problems).

Changing line 94 to the following fixes it:

        start-stop-daemon -o --stop --pidfile $PIDFILE --name squeezebox_safe

This is based on 7.4 r28080

Comment 1 Matt Wise 2009-08-06 08:03:00 UTC

 == Automatic comment from SVN commit #28083 to Repository: slim ==
https://svn.slimdevices.com/slim?view=revision&revision=28083

Bug 13265: Should solve the shutdown issue.


 == Modified 1 files total ==
7.4/trunk/platforms/debian/squeezebox.init

Comment 2 Andy Grundman 2009-08-06 16:51:12 UTC

 == Automatic comment from SVN commit #28087 to Repository: slim ==
https://svn.slimdevices.com/slim?view=revision&revision=28087

 r57579@macbookpro (orig r28080):  michael | 2009-08-06 02:38:06 -0400
 Bug: n/a
 Description: don't display download URL in web UI, unless we got an update message from SN including that URL. Don't check for downloads unless auto download is enabled.
 r57580@macbookpro (orig r28081):  andy | 2009-08-06 08:49:46 -0400
 Fixed Bug 13224 - simplify max mode, make it the default for everything, use it for pad mode.  Also added some more tests
 r57583@macbookpro (orig r28082):  andy | 2009-08-06 09:46:00 -0400
 Refactor S::W::Graphics to use ImageResizer
 r57596@macbookpro (orig r28083):  mwise | 2009-08-06 11:02:59 -0400
 Bug 13265: Should solve the shutdown issue.
 r57597@macbookpro (orig r28084):  mwise | 2009-08-06 11:45:22 -0400
 Bug 12962: Additional space at the end of the line caused the readynas init script to break.
 r57598@macbookpro (orig r28085):  andy | 2009-08-06 19:08:08 -0400
 Audio::Scan 0.28
 
 0.28    2009-08-06 19:00:00
         - Bug 13198, Changed the method for determining FLAC bitrate.
 
 0.27    2009-07-26 23:00:00
         - Added support for Musepack SV8 files.
         - Refactored Musepack code to use buffer API, fixes
           crashes on big-endian platforms.
         - Added support for reading Musepack track gain and album gain.
 r57599@macbookpro (orig r28086):  andy | 2009-08-06 19:41:16 -0400
 Fixed Bug 13252 - downgrade DBD::mysql to 3.0002 to fix crasher



 == Modified 27 files total ==
7.4/private-branches/baby-cat/
7.4/private-branches/baby-cat/platforms/debian/squeezebox.init
7.4/private-branches/baby-cat/platforms/readynas/rules
7.4/private-branches/baby-cat/platforms/readynas/squeezebox.init
7.4/private-branches/baby-cat/server/CPAN/Audio/Scan.pm
7.4/private-branches/baby-cat/server/CPAN/DBD/mysql/GetInfo.pm
7.4/private-branches/baby-cat/server/CPAN/DBD/mysql.pm
7.4/private-branches/baby-cat/server/CPAN/arch/5.10/MSWin32-x86-multi-thread/auto/Audio/Scan/Scan.dll
7.4/private-branches/baby-cat/server/CPAN/arch/5.10/MSWin32-x86-multi-thread/auto/DBD/mysql/mysql.dll
7.4/private-branches/baby-cat/server/CPAN/arch/5.10/darwin-thread-multi-2level/auto/Audio/Scan/Scan.bundle
7.4/private-branches/baby-cat/server/CPAN/arch/5.10/darwin-thread-multi-2level/auto/DBD/mysql/mysql.bundle
7.4/private-branches/baby-cat/server/CPAN/arch/5.10/i386-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/private-branches/baby-cat/server/CPAN/arch/5.10/i386-linux-thread-multi/auto/DBD/mysql/mysql.so
7.4/private-branches/baby-cat/server/CPAN/arch/5.10/x86_64-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/private-branches/baby-cat/server/CPAN/arch/5.10/x86_64-linux-thread-multi/auto/DBD/mysql/mysql.so
7.4/private-branches/baby-cat/server/CPAN/arch/5.8/darwin-thread-multi-2level/auto/Audio/Scan/Scan.bundle
7.4/private-branches/baby-cat/server/CPAN/arch/5.8/darwin-thread-multi-2level/auto/DBD/mysql/mysql.bundle
7.4/private-branches/baby-cat/server/CPAN/arch/5.8/i386-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/private-branches/baby-cat/server/CPAN/arch/5.8/i386-linux-thread-multi/auto/DBD/mysql/mysql.so
7.4/private-branches/baby-cat/server/CPAN/arch/5.8/sparc-linux/auto/Audio/Scan/Scan.so
7.4/private-branches/baby-cat/server/CPAN/arch/5.8/x86_64-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/private-branches/baby-cat/server/CPAN/arch/5.8/x86_64-linux-thread-multi/auto/DBD/mysql/mysql.so
7.4/private-branches/baby-cat/server/Slim/Utils/ImageResizer.pm
7.4/private-branches/baby-cat/server/Slim/Utils/Update.pm
7.4/private-branches/baby-cat/server/Slim/Web/Graphics.pm
7.4/private-branches/baby-cat/server/modules.conf
7.4/private-branches/baby-cat/tests/t/05resizer.t

 == Added 2 files total ==
7.4/private-branches/baby-cat/tests/data/images/ref/tall-cover-13x100.jpg
7.4/private-branches/baby-cat/tests/data/images/ref/wide-cover-100x12.jpg

 == Removed 2 files total ==
7.4/private-branches/baby-cat/platforms/readynas/CPAN/DBD/
7.4/private-branches/baby-cat/server/CPAN/arch/5.10/MSWin32-x86-multi-thread/auto/DBD/mysql/libmysql.dll

Comment 3 Andy Grundman 2009-08-06 16:58:39 UTC

 == Automatic comment from SVN commit #28088 to Repository: slim ==
https://svn.slimdevices.com/slim?view=revision&revision=28088

 r57579@macbookpro (orig r28080):  michael | 2009-08-06 02:38:06 -0400
 Bug: n/a
 Description: don't display download URL in web UI, unless we got an update message from SN including that URL. Don't check for downloads unless auto download is enabled.
 r57580@macbookpro (orig r28081):  andy | 2009-08-06 08:49:46 -0400
 Fixed Bug 13224 - simplify max mode, make it the default for everything, use it for pad mode.  Also added some more tests
 r57583@macbookpro (orig r28082):  andy | 2009-08-06 09:46:00 -0400
 Refactor S::W::Graphics to use ImageResizer
 r57596@macbookpro (orig r28083):  mwise | 2009-08-06 11:02:59 -0400
 Bug 13265: Should solve the shutdown issue.
 r57597@macbookpro (orig r28084):  mwise | 2009-08-06 11:45:22 -0400
 Bug 12962: Additional space at the end of the line caused the readynas init script to break.
 r57598@macbookpro (orig r28085):  andy | 2009-08-06 19:08:08 -0400
 Audio::Scan 0.28
 
 0.28    2009-08-06 19:00:00
         - Bug 13198, Changed the method for determining FLAC bitrate.
 
 0.27    2009-07-26 23:00:00
         - Added support for Musepack SV8 files.
         - Refactored Musepack code to use buffer API, fixes
           crashes on big-endian platforms.
         - Added support for reading Musepack track gain and album gain.
 r57599@macbookpro (orig r28086):  andy | 2009-08-06 19:41:16 -0400
 Fixed Bug 13252 - downgrade DBD::mysql to 3.0002 to fix crasher



 == Modified 27 files total ==
7.4/branches/noweb/
7.4/branches/noweb/platforms/debian/squeezebox.init
7.4/branches/noweb/platforms/readynas/rules
7.4/branches/noweb/platforms/readynas/squeezebox.init
7.4/branches/noweb/server/CPAN/Audio/Scan.pm
7.4/branches/noweb/server/CPAN/DBD/mysql/GetInfo.pm
7.4/branches/noweb/server/CPAN/DBD/mysql.pm
7.4/branches/noweb/server/CPAN/arch/5.10/MSWin32-x86-multi-thread/auto/Audio/Scan/Scan.dll
7.4/branches/noweb/server/CPAN/arch/5.10/MSWin32-x86-multi-thread/auto/DBD/mysql/mysql.dll
7.4/branches/noweb/server/CPAN/arch/5.10/darwin-thread-multi-2level/auto/Audio/Scan/Scan.bundle
7.4/branches/noweb/server/CPAN/arch/5.10/darwin-thread-multi-2level/auto/DBD/mysql/mysql.bundle
7.4/branches/noweb/server/CPAN/arch/5.10/i386-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/branches/noweb/server/CPAN/arch/5.10/i386-linux-thread-multi/auto/DBD/mysql/mysql.so
7.4/branches/noweb/server/CPAN/arch/5.10/x86_64-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/branches/noweb/server/CPAN/arch/5.10/x86_64-linux-thread-multi/auto/DBD/mysql/mysql.so
7.4/branches/noweb/server/CPAN/arch/5.8/darwin-thread-multi-2level/auto/Audio/Scan/Scan.bundle
7.4/branches/noweb/server/CPAN/arch/5.8/darwin-thread-multi-2level/auto/DBD/mysql/mysql.bundle
7.4/branches/noweb/server/CPAN/arch/5.8/i386-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/branches/noweb/server/CPAN/arch/5.8/i386-linux-thread-multi/auto/DBD/mysql/mysql.so
7.4/branches/noweb/server/CPAN/arch/5.8/sparc-linux/auto/Audio/Scan/Scan.so
7.4/branches/noweb/server/CPAN/arch/5.8/x86_64-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/branches/noweb/server/CPAN/arch/5.8/x86_64-linux-thread-multi/auto/DBD/mysql/mysql.so
7.4/branches/noweb/server/Slim/Utils/ImageResizer.pm
7.4/branches/noweb/server/Slim/Utils/Update.pm
7.4/branches/noweb/server/Slim/Web/Graphics.pm
7.4/branches/noweb/server/modules.conf
7.4/branches/noweb/tests/t/05resizer.t

 == Added 2 files total ==
7.4/branches/noweb/tests/data/images/ref/tall-cover-13x100.jpg
7.4/branches/noweb/tests/data/images/ref/wide-cover-100x12.jpg

 == Removed 2 files total ==
7.4/branches/noweb/platforms/readynas/CPAN/DBD/
7.4/branches/noweb/server/CPAN/arch/5.10/MSWin32-x86-multi-thread/auto/DBD/mysql/libmysql.dll

Comment 4 Andy Grundman 2009-08-06 17:02:53 UTC

 == Automatic comment from SVN commit #28089 to Repository: slim ==
https://svn.slimdevices.com/slim?view=revision&revision=28089

 r57601@macbookpro (orig r28088):  andy | 2009-08-06 19:58:37 -0400
  r57579@macbookpro (orig r28080):  michael | 2009-08-06 02:38:06 -0400
  Bug: n/a
  Description: don't display download URL in web UI, unless we got an update message from SN including that URL. Don't check for downloads unless auto download is enabled.
  r57580@macbookpro (orig r28081):  andy | 2009-08-06 08:49:46 -0400
  Fixed Bug 13224 - simplify max mode, make it the default for everything, use it for pad mode.  Also added some more tests
  r57583@macbookpro (orig r28082):  andy | 2009-08-06 09:46:00 -0400
  Refactor S::W::Graphics to use ImageResizer
  r57596@macbookpro (orig r28083):  mwise | 2009-08-06 11:02:59 -0400
  Bug 13265: Should solve the shutdown issue.
  r57597@macbookpro (orig r28084):  mwise | 2009-08-06 11:45:22 -0400
  Bug 12962: Additional space at the end of the line caused the readynas init script to break.
  r57598@macbookpro (orig r28085):  andy | 2009-08-06 19:08:08 -0400
  Audio::Scan 0.28
  
  0.28    2009-08-06 19:00:00
          - Bug 13198, Changed the method for determining FLAC bitrate.
  
  0.27    2009-07-26 23:00:00
          - Added support for Musepack SV8 files.
          - Refactored Musepack code to use buffer API, fixes
            crashes on big-endian platforms.
          - Added support for reading Musepack track gain and album gain.
  r57599@macbookpro (orig r28086):  andy | 2009-08-06 19:41:16 -0400
  Fixed Bug 13252 - downgrade DBD::mysql to 3.0002 to fix crasher
 



 == Modified 20 files total ==
7.4/branches/noweb-sqlite/
7.4/branches/noweb-sqlite/platforms/debian/squeezebox.init
7.4/branches/noweb-sqlite/platforms/readynas/rules
7.4/branches/noweb-sqlite/platforms/readynas/squeezebox.init
7.4/branches/noweb-sqlite/server/CPAN/Audio/Scan.pm
7.4/branches/noweb-sqlite/server/CPAN/arch/5.10/MSWin32-x86-multi-thread/auto/Audio/Scan/Scan.dll
7.4/branches/noweb-sqlite/server/CPAN/arch/5.10/MSWin32-x86-multi-thread/auto/DBD/mysql/mysql.dll
7.4/branches/noweb-sqlite/server/CPAN/arch/5.10/darwin-thread-multi-2level/auto/Audio/Scan/Scan.bundle
7.4/branches/noweb-sqlite/server/CPAN/arch/5.10/darwin-thread-multi-2level/auto/DBD/mysql/mysql.bundle
7.4/branches/noweb-sqlite/server/CPAN/arch/5.10/i386-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/branches/noweb-sqlite/server/CPAN/arch/5.10/x86_64-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/branches/noweb-sqlite/server/CPAN/arch/5.8/darwin-thread-multi-2level/auto/Audio/Scan/Scan.bundle
7.4/branches/noweb-sqlite/server/CPAN/arch/5.8/i386-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/branches/noweb-sqlite/server/CPAN/arch/5.8/sparc-linux/auto/Audio/Scan/Scan.so
7.4/branches/noweb-sqlite/server/CPAN/arch/5.8/x86_64-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/branches/noweb-sqlite/server/Slim/Utils/ImageResizer.pm
7.4/branches/noweb-sqlite/server/Slim/Utils/Update.pm
7.4/branches/noweb-sqlite/server/Slim/Web/Graphics.pm
7.4/branches/noweb-sqlite/server/modules.conf
7.4/branches/noweb-sqlite/tests/t/05resizer.t

 == Added 2 files total ==
7.4/branches/noweb-sqlite/tests/data/images/ref/tall-cover-13x100.jpg
7.4/branches/noweb-sqlite/tests/data/images/ref/wide-cover-100x12.jpg

 == Removed 2 files total ==
7.4/branches/noweb-sqlite/platforms/readynas/CPAN/DBD/
7.4/branches/noweb-sqlite/server/CPAN/arch/5.10/MSWin32-x86-multi-thread/auto/DBD/mysql/libmysql.dll

Comment 5 Andy Grundman 2009-08-06 17:10:05 UTC

 == Automatic comment from SVN commit #28090 to Repository: slim ==
https://svn.slimdevices.com/slim?view=revision&revision=28090

 r57579@macbookpro (orig r28080):  michael | 2009-08-06 02:38:06 -0400
 Bug: n/a
 Description: don't display download URL in web UI, unless we got an update message from SN including that URL. Don't check for downloads unless auto download is enabled.
 r57580@macbookpro (orig r28081):  andy | 2009-08-06 08:49:46 -0400
 Fixed Bug 13224 - simplify max mode, make it the default for everything, use it for pad mode.  Also added some more tests
 r57583@macbookpro (orig r28082):  andy | 2009-08-06 09:46:00 -0400
 Refactor S::W::Graphics to use ImageResizer
 r57596@macbookpro (orig r28083):  mwise | 2009-08-06 11:02:59 -0400
 Bug 13265: Should solve the shutdown issue.
 r57597@macbookpro (orig r28084):  mwise | 2009-08-06 11:45:22 -0400
 Bug 12962: Additional space at the end of the line caused the readynas init script to break.
 r57598@macbookpro (orig r28085):  andy | 2009-08-06 19:08:08 -0400
 Audio::Scan 0.28
 
 0.28    2009-08-06 19:00:00
         - Bug 13198, Changed the method for determining FLAC bitrate.
 
 0.27    2009-07-26 23:00:00
         - Added support for Musepack SV8 files.
         - Refactored Musepack code to use buffer API, fixes
           crashes on big-endian platforms.
         - Added support for reading Musepack track gain and album gain.
 r57599@macbookpro (orig r28086):  andy | 2009-08-06 19:41:16 -0400
 Fixed Bug 13252 - downgrade DBD::mysql to 3.0002 to fix crasher



 == Modified 27 files total ==
7.4/private-branches/fab4/
7.4/private-branches/fab4/platforms/debian/squeezebox.init
7.4/private-branches/fab4/platforms/readynas/rules
7.4/private-branches/fab4/platforms/readynas/squeezebox.init
7.4/private-branches/fab4/server/CPAN/Audio/Scan.pm
7.4/private-branches/fab4/server/CPAN/DBD/mysql/GetInfo.pm
7.4/private-branches/fab4/server/CPAN/DBD/mysql.pm
7.4/private-branches/fab4/server/CPAN/arch/5.10/MSWin32-x86-multi-thread/auto/Audio/Scan/Scan.dll
7.4/private-branches/fab4/server/CPAN/arch/5.10/MSWin32-x86-multi-thread/auto/DBD/mysql/mysql.dll
7.4/private-branches/fab4/server/CPAN/arch/5.10/darwin-thread-multi-2level/auto/Audio/Scan/Scan.bundle
7.4/private-branches/fab4/server/CPAN/arch/5.10/darwin-thread-multi-2level/auto/DBD/mysql/mysql.bundle
7.4/private-branches/fab4/server/CPAN/arch/5.10/i386-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/private-branches/fab4/server/CPAN/arch/5.10/i386-linux-thread-multi/auto/DBD/mysql/mysql.so
7.4/private-branches/fab4/server/CPAN/arch/5.10/x86_64-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/private-branches/fab4/server/CPAN/arch/5.10/x86_64-linux-thread-multi/auto/DBD/mysql/mysql.so
7.4/private-branches/fab4/server/CPAN/arch/5.8/darwin-thread-multi-2level/auto/Audio/Scan/Scan.bundle
7.4/private-branches/fab4/server/CPAN/arch/5.8/darwin-thread-multi-2level/auto/DBD/mysql/mysql.bundle
7.4/private-branches/fab4/server/CPAN/arch/5.8/i386-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/private-branches/fab4/server/CPAN/arch/5.8/i386-linux-thread-multi/auto/DBD/mysql/mysql.so
7.4/private-branches/fab4/server/CPAN/arch/5.8/sparc-linux/auto/Audio/Scan/Scan.so
7.4/private-branches/fab4/server/CPAN/arch/5.8/x86_64-linux-thread-multi/auto/Audio/Scan/Scan.so
7.4/private-branches/fab4/server/CPAN/arch/5.8/x86_64-linux-thread-multi/auto/DBD/mysql/mysql.so
7.4/private-branches/fab4/server/Slim/Utils/ImageResizer.pm
7.4/private-branches/fab4/server/Slim/Utils/Update.pm
7.4/private-branches/fab4/server/Slim/Web/Graphics.pm
7.4/private-branches/fab4/server/modules.conf
7.4/private-branches/fab4/tests/t/05resizer.t

 == Added 2 files total ==
7.4/private-branches/fab4/tests/data/images/ref/tall-cover-13x100.jpg
7.4/private-branches/fab4/tests/data/images/ref/wide-cover-100x12.jpg

 == Removed 2 files total ==
7.4/private-branches/fab4/platforms/readynas/CPAN/DBD/
7.4/private-branches/fab4/server/CPAN/arch/5.10/MSWin32-x86-multi-thread/auto/DBD/mysql/libmysql.dll

Comment 6 James Richardson 2009-10-05 14:28:02 UTC

This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.