Bugzilla – Bug 13264
If sleeping at end of song, don't start crossfading the next track
Last modified: 2009-10-21 09:45:52 UTC
I know I fixed this once before, so this is a minor regression.
Hmm Deskzilla doesn't work right with priority on new bugs...
this is an administrative shuffle on priority fields to help make better judgment on the top end of the priority list. P4->P5, P3->P4, and P2->P3.
Andy, I'm willing to give this a shot if you can point me in a direction. Could this be a simple matter of overriding the $transitionType packed into the strm frame from S::P::Squeezebox::stream_s() ?
Thanks. Yeah, I think when I fixed this before I just had a check somewhere that wouldn't set transitionType if we were going to sleep. Or don't start streaming the next track at all, that may have been the fix. There is another related bug. When sleeping and the players are synced, the slow volume fade out only fades on one of the synced players. Been meaning to file that one...
That second part needs to be a different bug. There are complications of the sync prefs that would effect how the group reacts to sleeping and fading (prefs for syncing power and volume with the group to be specific). I'll borrow a bit of code from $client->prettySleepTime that decides if sleep is near the end of a song (even if randomly happens to be near the end of a song) and override the strm frame. I should have time to test that tonight and post results here.
Created attachment 5947 [details] override transition type when sleeping at end of song Patch simply checks if there is a sleep even that is within a minute of the current song end. If so, we override the transition so that no crossfading will take place.
Created attachment 5948 [details] log log snippet showing the patch in effect. Setting is currently for Crossfade, but the patch will simply override for any setting of transitionType
Feel free to check this into trunk (7.4.1). Thanks!
== Auto-comment from SVN commit #28675 to the slim repo by kdf == == https://svn.slimdevices.com/slim?view=revision&revision=28675 == Bug: 13264 Description: check sleep time and remaining song time. If the sleep event is set to match up with the end of the song, override the transition settings to prevent any crossfade.
Verified fixed in 7.4.1 r28825 // SP r7847 Thanks for the patch KDF :)