Bug 13225 - Make different calls to imageproxy depending on which Now Playing skin is being used
: Make different calls to imageproxy depending on which Now Playing skin is bei...
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Now Playing
: unspecified
: PC Other
: -- normal (vote)
: 7.4.0
Assigned To: Adrian Smith
:
Depends on: 13224
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-03 18:18 UTC by Andy Grundman
Modified: 2009-10-05 14:32 UTC (History)
4 users (show)

See Also:
Category: Feature


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Grundman 2009-08-03 18:18:36 UTC

    
Comment 1 Adrian Smith 2009-08-04 01:10:12 UTC
I suggest that we allow the skin to specify image sizes as "200x100" format as well as just "100".  We then use this to send the required width and height to the resizer.  

Only change is to SlimServer:fetchArtwork to allow the size param to be as above?

It will work for all current skins as they only have a single size dimension.  I would like to set this for some skins's now playing screen so I can resize retangular artwork to fill the screen.

Note - this also assumes my proposal for the resizing semantics X by Y means return an image of a max width of X, max height of Y, but retain the current aspect ratio.

I can do if agreed.
Comment 2 Andy Grundman 2009-08-04 04:33:11 UTC
Yeah that sounds like a good way to do it.
Comment 3 Ben Klaas 2009-08-07 08:45:51 UTC
Adrian-- sounds good. assigning to you since you volunteered :)
Comment 4 Adrian Smith 2009-08-07 09:04:10 UTC
see patch on campfire - where does this need to be committed?
Comment 5 Andy Grundman 2009-08-07 09:16:10 UTC
Sorry I hardly ever check the Baby room.  Patch should go in SP's fab4 branch.
Comment 6 SVN Bot 2009-08-07 13:12:01 UTC
 == Auto-comment from SVN commit #6960 to the jive repo by adrian ==
 == https://svn.slimdevices.com/jive?view=revision&revision=6960 ==

Bug: 13225
Description: allow artwork size to be rectangular and use max mode resizing on the server to resize to this.  Initially only used for QVGAlandscape np artwork
Comment 7 James Richardson 2009-10-05 14:32:59 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.