Bug 13193 - If WEP password is incorrectly entered the first time, you can't fix it.
: If WEP password is incorrectly entered the first time, you can't fix it.
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Setup
: unspecified
: PC Other
: P1 major (vote)
: 7.4.0
Assigned To: James Richardson
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-01 13:37 UTC by Weldon Matt
Modified: 2009-10-05 14:31 UTC (History)
3 users (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Weldon Matt 2009-08-01 13:37:55 UTC
Performing setup after a factory reset, I incorrectly entered a 10-digit password (one digit was wrong).

I was given no option to re-enter my password.  And when I tried to back up and choose the same network again, instead of being prompted for my password, Baby kept automatically trying to connect with the previously entered (incorrect) password.

Basically, I was totally stuck.  Had to perform a factory reset in order to erase the player's memory of the entered password and try again.

I also don't quite remember now, but I don't think the WEP error screen gave me the option to choose a different network - just to "try again."  

What SHOULD happen: 

- the error screen should give me an option to re-enter the password.
Comment 1 Wadzinski Tom 2009-08-03 12:34:10 UTC
I can reproduce this if I enter a wrong password then back back back all the 
way out to choose network. Then it seems the incorrect WEP password is saved 
and there is no path to changing it.
Comment 2 Wadzinski Tom 2009-08-03 13:15:53 UTC
I think the least invasive fix is to make WEP's "Try Again" work more like the 
non-WEP case, that is, to re-offer the password screen. Instead, in the WEP 
case, the following is called:

{
			text = self:string("NETWORK_TRY_AGAIN"),
			sound = "WINDOWHIDE",
			callback = function()
				-- poke udhcpto try again
				_sigusr1("udhcpc")
				_connect(self, iface, ssid, false, false)
				window:hide(Window.transitionNone)
			end
		},

I would have expected it to be something more like the non-WEP case shown 
below. I'm not sure why WEP's Try Again is different this way, and I'm not 
comfortable changing it without Felix's input:

			text = self:string("NETWORK_TRY_AGAIN"),
			sound = "WINDOWHIDE",
			callback = function()
				_networkScanAgain(self, iface, true)
				_enterPassword(self, iface, ssid, "config")
			end
Comment 3 Felix Mueller 2009-08-03 13:31:54 UTC
Richard invented that part of the networking setup code. What you suggest, Tom, looks ok to me (does it actually solve the issue? I have not tried it). But I would like to hear what Richard thinks about it.
Comment 4 Wadzinski Tom 2009-08-03 14:37:00 UTC
Fixed for MP r6897
Fix is to offer "Re-enter password" at two points where WEP connection may fail 
due to incorrect password
Comment 5 Wadzinski Tom 2009-08-03 14:37:53 UTC
Reassigning to Richard for review and merge into main fab4 branch
Comment 6 Wadzinski Tom 2009-08-03 14:45:12 UTC
To reproduce both cases

1) From factory reset, enter incorrect WEP password
2) After incorrect WEP password enter, reboot and select the same WEP network. It will try to connecting using the failed PW and then offer a DHCP style error page where you can do "re-enter password"

Ideally, the pw would be cleared instead in various cases, but I don't feel comfortabel about those changes, and I don't think that that is critical.
Comment 7 Richard Titmuss 2009-08-04 05:38:04 UTC
Reviewed and merged in r6900
Comment 8 James Richardson 2009-08-14 15:01:39 UTC
This appears to be a regression in MP 7022
Comment 9 Wadzinski Tom 2009-08-14 15:50:15 UTC
with r7022, this may have regressed also for WPA and WPA2, not just WEP, though WPA and WPA2 "Try again" is working for Steven, not James.

Also, a note from Steven from Campfire:
The thing is if I select back and correct the password and it fails and then I select Try Again it will still fail
Comment 10 Wadzinski Tom 2009-08-17 08:19:49 UTC
I can't reproduce this, with WPA2 or WEP. Reassigning to James. James can you provide complete details of the steps used to reproduce, with for instance WPA2, including which router you are using. Then re-assign to Felix.
Comment 11 James Richardson 2009-08-17 08:32:42 UTC
https://bugs-archive.lyrion.org/show_bug.cgi?id=11771#c35

Felix is correct in that statement, when using a Non-WPS router, this error does not happen.

Marking a fixed again
Comment 12 James Richardson 2009-10-05 14:31:20 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.