Bugzilla – Bug 13126
Supporting text should be vertically centered
Last modified: 2009-10-05 14:38:09 UTC
Noah pushed really hard for this for a while but I resisted. After playing with the design for a few weeks, I now agree with him. (In fact maybe I was the lone holdout :-). On screens with supporting text + selectable options, the supporting text should be vertically centered in the area it "lives" in. As you know there are many cases where there is a large amount of empty space below the supporting text and the menu options, and we'd like this to look a bit better.
I'm anticipating this will not be as straight forward as a skin change, so estimating 4hrs for it
Tried setting a skin param of h = WH_FILL but that caused jive to choke as it tried to make the height of the headerWidget much much larger than needed. It does not appear there is any way to do vertical centering of textarea widgets in the skin right now. this section from src/ui/jive_textarea.c seems promising, but I don't know what to do with it. /* vertical alignment */ widget_height = peer->w.bounds.h - peer->w.padding.top - peer->w.padding.bottom; max_height = peer->num_lines * peer->line_height; /* todo:why this here, seems to be a vertical centering*/ if (max_height < widget_height) { peer->y_offset = (widget_height - max_height) / 2; } else { peer->y_offset = 0; } Apologies, but this fix is beyond Lua. Punting to Tom for feedback. In an ideal world a widget style could have an optional verticalAlign param in addition to the align param, which seems to mostly be about horizontal alignment. Options for verticalAlign would be top, center, bottom.
== Auto-comment from SVN commit #7470 to the jive repo by tom == == https://svn.slimdevices.com/jive?view=revision&revision=7470 == Fixed Bug:13126 Description: - headerWidget now vertically aligned
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server! * SqueezeCenter: 28672 * Squeezebox 2 and 3: 130 * Transporter: 80 * Receiver: 65 * Boom: 50 * Controller: 7790 * Radio: 7790 Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.