Bug 13097 – Item with nextWindow but no actions doesn't work

Bug 13097 - Item with nextWindow but no actions doesn't work

Summary:

Item with nextWindow but no actions doesn't work

Status:	CLOSED FIXED

Product:	SqueezePlay
Classification:	Unclassified
Component:	Browser
Version:	unspecified
Platform:	PC Other

Importance:	P1 normal (vote)
Target Milestone:	CXR
Assigned To:	Andy Grundman

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-07-28 12:28 UTC by Andy Grundman
Modified:	2009-10-06 09:22 UTC (History)
CC List:	3 users (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andy Grundman 2009-07-28 12:28:51 UTC

An item like this:

{ actions => undef, nextWindow => "home", text => "Continue" },

Doesn't push home but bumps.

Will apply this patch to fix it, I believe it's safe:

--- squeezeplay/share/applets/SlimBrowser/SlimBrowserApplet.lua	(revision 6823)
+++ squeezeplay/share/applets/SlimBrowser/SlimBrowserApplet.lua	(working copy)
@@ -1600,7 +1600,8 @@
 				end
 			
 			-- not item action, look for a base one
-			elseif bAction then
+			elseif bAction and not nextWindow then
 				log:debug("_actionHandler(", actionName, "): base action")
 			
 				-- found a json command

Comment 1 Andy Grundman 2009-07-28 12:29:41 UTC

Fixed in r6826.

Comment 2 James Richardson 2009-10-06 09:22:07 UTC

This bug has been fixed in the latest release of MySqueezebox.com (formally
known as SqueezeNetwork)!

If you are still experiencing this problem, feel free to reopen the bug with
your new comments and we'll have another look.