Bug 13062 - Songinfo Query fails in 7.4
: Songinfo Query fails in 7.4
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: CLI
: 7.4.0
: Other Ubuntu Linux
: P1 normal (vote)
: 7.4.0
Assigned To: Andy Grundman
: ipeng
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-26 07:11 UTC by Joerg Schwieder
Modified: 2009-10-05 14:33 UTC (History)
3 users (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joerg Schwieder 2009-07-26 07:11:56 UTC
I'm doing the following query in iPeng to get the album ID of a track:

[code]
["",["songinfo",0,100,"track_id:8338","tags:e"]]
[/code]

This works fine in 7.3 but fails in 7.4, in the log file I get:
[code]
[09-07-26 16:06:56.6391] Slim::Web::JSONRPC::requestMethod (358) Request failed with error: Bad dispatch!
[09-07-26 16:06:56.6667] Slim::Control::Request::execute (1911) Error: While trying to run function coderef [Slim::Control::Queries::songinfoQuery]: [Can't call method "currentSongForUrl" on an undefined value at /usr/share/perl5/Slim/Control/Queries.pm line 5046.
]
[/code]
Comment 1 Michael Herger 2009-07-27 01:07:08 UTC
Alan - songinfo is a database query and should not require a client object. But the current code does:

if (my $song = $request->client->currentSongForUrl($track->url)) {
	my $t = $song->currentTrack();
	if ($t->url ne $track->url) {
		$parentTrack = $track;
		$track = $t;
	}
}

We should probably check for a client before calling this?
Comment 2 Michael Herger 2009-07-30 22:47:05 UTC
Andy - this is sqlite branch change only. No need to fix in 7.4 unless we backport Alan's meta data changes.
Comment 3 Andy Grundman 2009-08-03 16:34:54 UTC
Fixed in change 28027.
Comment 4 James Richardson 2009-10-05 14:33:28 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.