Bug 1306 - Get duplicate artist entries when using artist separator characters
: Get duplicate artist entries when using artist separator characters
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Tagging
: 6.1.0
: PC All
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-04-04 16:04 UTC by Ben Sandee
Modified: 2009-09-08 09:28 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Multiple artist track (3.09 MB, application/octet-stream)
2005-04-04 16:06 UTC, Ben Sandee
Details
Single artist track (2.24 MB, application/octet-stream)
2005-04-04 16:08 UTC, Ben Sandee
Details
slimserver.db that has duplicate artists (2.99 MB, application/octet-stream)
2005-04-18 20:42 UTC, Ben Sandee
Details
possible fix (737 bytes, patch)
2005-04-23 17:41 UTC, Vidur Apparao
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Sandee 2005-04-04 16:04:17 UTC
I've got an artist that appears both as a soloist (sole artist for an album) and
then in collaboration with another artist.  I have set the semicolon ";" as my
tag delimiter and set the tags appropriately for the second album.  The two sets
of tracks and not merged however (I did a db rescan).

The artist in question is "Bonnie 'Prince' Billy" and I've attached two mp3
files to the bug.
Comment 1 Ben Sandee 2005-04-04 16:06:26 UTC
Created attachment 396 [details]
Multiple artist track
Comment 2 Ben Sandee 2005-04-04 16:08:16 UTC
Created attachment 397 [details]
Single artist track
Comment 3 Vidur Apparao 2005-04-18 18:04:21 UTC
This works for me, but you will need to do a Wipe Cache (on the Server Settings
> Performance page of the web interface) to see it - a rescan does not remove
older entries. We will be improving the interface for Rescan vs Wipe Cache
fairly soon to make them less confusing.
Comment 4 Ben Sandee 2005-04-18 18:48:57 UTC
I'll reverify with the latest svn (I update every night) but I should have said
in the bug report that I did a database rebuild from scratch (deleted the .db file).
Comment 5 Ben Sandee 2005-04-18 20:35:46 UTC
No, I still see the dup artists even using the latest trunk build.  I'll attach
my  DB file, maybe that will help identify the problem.
Comment 6 Ben Sandee 2005-04-18 20:42:35 UTC
Created attachment 432 [details]
slimserver.db that has duplicate artists
Comment 7 Vidur Apparao 2005-04-23 14:57:39 UTC
Still no luck in recreating it here. I'm using a straight directory scan, no
iTunes, etc. 

The .db file you attached earlier definitely shows two artist entries with
identical names. Since we key on the individual artist's name, I can't think of
why we'd have more than one object. Are the tracks coming in through different
import paths?
Comment 8 Vidur Apparao 2005-04-23 15:42:51 UTC
OK. I've got a theory. What happens if you create a temporary audio directory
which just the two tracks and do a Wipe cache? My guess is that you'll only have
a single artist entry in that case.
Comment 9 Vidur Apparao 2005-04-23 17:41:50 UTC
Created attachment 453 [details]
possible fix

Alternatively, can you try this patch and a Wipe Cache?
Comment 10 Ben Sandee 2005-04-23 21:45:11 UTC
YES that works perfectly!  Thank you so much Vidur!


Comment 11 Vidur Apparao 2005-04-24 11:10:34 UTC
Fixed on trunk (change 3058) and branch (change 3059).
Comment 12 Ben Sandee 2005-06-06 06:53:58 UTC
this bug cropped up again with the latest svn.  Looking through the history, I
suspect the fix for bug 1548, svn 3335.  I don't have anything except my
intuition though.
Comment 13 Blackketter Dean 2005-06-10 16:44:15 UTC
the correct solution for this is to add a third name column.  we would then have a "display name" a 
"sortable name" and a "unique identifier name".
Comment 14 Ben Sandee 2005-06-10 20:34:19 UTC
What would the third column have that would tie these two artists together? 
They already have the same sort name and display name -- how would the unique id
fix this? 

This was working fine for most of the 6.1 lifecycle and it regressed just
recently so I really think there's a good chance it's an oversight in the patch
I mentioned.
Comment 15 Ben Sandee 2005-06-10 20:38:09 UTC
oh, well they wouldn't necessarily have the same sort name -- that's true.  the
tags from the id3 might have a tsop of Billy, Bonnie 'Prince' (although they
don't) and the tags from the "split" track would not have the tsop so the sort
order keys wouldn't match.  Is that why things are being split up?
Comment 16 Ben Sandee 2005-08-05 16:59:34 UTC
I'm still seeing this and was wondering if it might make sense to address this
at the same time as you address the problem now added as a result of the new
various artists code.  If I do a search for an artist name where the artist is
both a soloist and contributes to a various artist collection album, I get two
items with the artist name but different contents depending on the source.  It
seems like somewhere we just need to make sure that artists with the exact same
name are folded together at *display* time even if we need to keep them separate
for database housekeeping.

Any comments?
Comment 17 Blackketter Dean 2005-08-21 17:46:14 UTC
Dan, does this mesh in with the VA support?
Comment 18 Dan Sully 2005-08-23 18:26:03 UTC
Ben - I believe some fixes in the latest nightlies help with this.

The artist display looks fine to me.

Also - I noticed your tags are slightly incorrect:

ARTIST => Bonnie 'Prince' Billy;Matt Sweeney

ARTISTSORT => Bonnie 'Prince' Billy & Matt Sweeney
Comment 19 Ben Sandee 2005-08-23 18:58:23 UTC
I'll check out the latest builds -- thanks!

I'm not sure how the artistsort tag will actually work when it's being split --
any insight?  Should my tags be:

ARTIST => Bonnie 'Prince' Billy;Matt Sweeney

ARTISTSORT => Bonnie 'Prince' Billy;Sweeney, Matt

And would SS correctly place "Matt Sweeney" under "S" and Bonnie 'Prince' Billy
under "B"?
Comment 20 Dan Sully 2005-08-23 20:13:49 UTC
Yes, that is correct.
Comment 21 Ben Sandee 2005-08-24 10:49:15 UTC
Yes, Dan the latest builds appears to fix the problem.  I'm still having some
issues with the TSOP tags, but this is definitely a separate issue.

Thanks!