Bug 13044 - Add XMLBrowser type=input support (Recent Searches stores everything)
: Add XMLBrowser type=input support (Recent Searches stores everything)
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Controller
: 7.4.0
: PC Other
: P1 critical (vote)
: 7.4.0
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-24 14:27 UTC by Andy Grundman
Modified: 2009-10-05 14:35 UTC (History)
4 users (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Grundman 2009-07-24 14:27:07 UTC
App account entry uses type=search fields, and so Recent Searches happily stores your username and password and displays it in the recent searches list.  Need to come up with a way to exclude certain items.
Comment 1 Andy Grundman 2009-07-24 14:28:12 UTC
Maybe need to add type=input, which is the same thing but not considered a "search".
Comment 2 Ben Klaas 2009-08-04 21:16:18 UTC
this is XMLBrowser's if clause for caching a search:

 if ( $request->isQuery([[$query], ['items']]) && defined($request->getParam('menu')) && defined($request->getParam('search')) ) {

I don't know which app account entry you are talking about, but wherever that code resides I think you just need to send something over to make it not return true from this clause. type=input, donotcache=1...whatever works.

Andy, I think this is yours to fix then?
Comment 3 Andy Grundman 2009-08-04 21:19:30 UTC
OK I will add type=input.
Comment 4 SVN Bot 2009-08-31 13:51:21 UTC
 == Auto-comment from SVN commit #7166 to the network repo by andy ==
 == https://svn.slimdevices.com/network?view=revision&revision=7166 ==

Bug 13044, flag search items that should not be cached
Comment 5 SVN Bot 2009-08-31 13:51:45 UTC
 == Auto-comment from SVN commit #28395 to the slim repo by andy ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28395 ==

Fixed bug 13044, use cachesearch flag to avoid caching certain search items
Comment 6 James Richardson 2009-10-05 14:35:58 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.