Bug 12989 - Disconnected wireless and Baby crashed (with Rhapsody)
: Disconnected wireless and Baby crashed (with Rhapsody)
Status: CLOSED FIXED
Product: SB Radio
Classification: Unclassified
Component: Networking
: Include FW version in comment
: PC Windows XP
: P1 major (vote)
: 7.4.0
Assigned To: Richard Titmuss
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-22 16:37 UTC by Ryan
Modified: 2009-10-05 14:30 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan 2009-07-22 16:37:03 UTC
While playing a streem from Rapsody I unplugged power to the wireless router and when the song in the buffer was complete Baby crashed.
Comment 1 James Richardson 2009-07-23 09:54:59 UTC
Ryan: Can you reproduce this with NO audio playing, or with a different audio stream?
Comment 2 Richard Titmuss 2009-07-24 02:43:36 UTC
Not an MP issue. Ryan did you get a crash log message when it rebooted, if not it's probably a case of bug 12602.
Comment 3 Richard Titmuss 2009-07-27 01:09:52 UTC
Reset priority before triage.
Comment 4 Ryan 2009-07-27 08:12:17 UTC
Yrs there was a crash log message when it rebooted
Comment 5 Pat Ransil 2009-07-31 10:50:53 UTC
Reassigning to Richard.
Comment 6 Richard Titmuss 2009-08-07 14:12:01 UTC
Is this repeatable?
Comment 7 James Richardson 2009-08-07 14:24:18 UTC
I am not able to replicate this on r6950

Either with a track playing, or no track playing.
Comment 8 Ryan 2009-09-03 09:00:59 UTC
r7360   This seems to have come back but when used with wired connection. While playing Rhapsody I unplugged the ethernet, baby played through the buffer then shortly after it crashed and rebooted.
Comment 9 Richard Titmuss 2009-09-08 13:11:40 UTC
ryan, can you please get a log. (or let me know your mac address and the time the crash happened so i can check the uploaded crash logs).
Comment 10 Ryan 2009-09-08 16:00:52 UTC
mac 000420260083  there should be a log at 3:45 pm  currently running r7451 which is the version that connects to the special server for the CAT testing

I was running wired and unplugged the ethernet cable. It does not happen every time.

I had previously set the error log to always log so it should be there.
Comment 11 Chris Owens 2009-09-14 08:50:27 UTC
Raising the severity of this bug due to it affecting our Rhapsody certification.  Ryan, if Richard has additional questions on this bug, please make them a very high priority for you.  Thanks!
Comment 12 Chris Owens 2009-09-15 09:00:49 UTC
Ryan, could you add the verbatim text from the Rhapsody test case to this bug?  Thanks.
Comment 13 Richard Titmuss 2009-09-15 09:02:04 UTC
This is the log, lots of:

Sep  8 12:04:10 squeezeplay: playback_callback:328 Audio underrun: used 0 bytes
Sep  8 12:04:10 squeezeplay: playback_callback:328 Audio underrun: used 0 bytes
Sep  8 12:04:10 squeezeplay: playback_callback:328 Audio underrun: used 0 bytes
Sep  8 12:04:10 squeezeplay: playback_callback:328 Audio underrun: used 0 bytes

Then a semaphore timeout.
Comment 14 Ryan 2009-09-15 09:31:44 UTC
Per Chris's request The Rhapsody certification requirements include the
following text.

"
Connection Issue:  Verify an appropriate message is displayed if there are
connection issues (e.g., lost connection)

Disconnect the internet cable or turn-off the wireless access point.  The
device should provide a user friendly message indicating the connection is no
longer available.

Required
"
Comment 15 Chris Owens 2009-09-16 10:04:33 UTC
We've slipped by in the past from the strict requirement of displaying a message by pointing out our amazing buffer.  However a crash and reboot on the recovery kind of tips us over the edge.
Comment 16 SVN Bot 2009-09-16 15:04:12 UTC
 == Auto-comment from SVN commit #6417 to the player repo by richard ==
 == https://svn.slimdevices.com/player?view=revision&revision=6417 ==

Bug #12989
Fixed minor bugs in rhapsody code after review.
Comment 17 SVN Bot 2009-09-16 15:06:52 UTC
 == Auto-comment from SVN commit #7624 to the jive repo by richard ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7624 ==

Bug #12989
Fixed two crashers that could happen when streaming rhapsody.
1. buffer overrun in jive_alsa
2. if the streambuf does not have enough data in it the rhapsody filter loop, starving the main thread and 
preventing the streambuf from filling.
Comment 18 Richard Titmuss 2009-09-16 15:09:47 UTC
This maybe now fixed, certainly two causes of crashing/lockup are fixed. I've only tested on the desktop build not on the hardware, so it is possible that a blocking ssl call would still cause a watchdog timeout and reboot.
Comment 19 Ryan 2009-09-16 16:51:14 UTC
r7625  tested this and it still causes reboots but not every time

check crash logs for mac: 00:04:20:26:00:83  around 4:40 pm
Comment 20 Ryan 2009-09-16 17:03:52 UTC
r7625  still crashes reboots check log for mac 00:04:20:26:00:83 at 5:00 pm
Comment 21 SVN Bot 2009-09-17 02:25:41 UTC
 == Auto-comment from SVN commit #6419 to the player repo by richard ==
 == https://svn.slimdevices.com/player?view=revision&revision=6419 ==

Bug #12989
Fix streambuf locking when doing Rhapsody requests. As the streambuf was locked, if the EA request blocked 
this would eventually lead to the whole process blocking.
Comment 22 SVN Bot 2009-09-17 02:26:02 UTC
 == Auto-comment from SVN commit #7632 to the jive repo by richard ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7632 ==

Bug #12989
Fix streambuf locking when doing Rhapsody requests. As the streambuf was locked, if the EA request blocked 
this would eventually lead to the whole process blocking.
Comment 23 Richard Titmuss 2009-09-17 03:03:25 UTC
I've tested this last fix on the hardware, I think it's working ok now.
Comment 24 Ryan 2009-09-17 11:21:37 UTC
r7642  it is no longer causing crash and reboots (tested 6 times) there are other issues which I will report in another new bug
Comment 25 James Richardson 2009-10-05 14:30:00 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.