Bugzilla – Bug 1290
can't get cuesheet from invalid flac files (was: flac produced from eac won't parse)
Last modified: 2009-11-11 14:35:07 UTC
Slimserver currently can't correctly parse the cuesheet block from files with cuesheets embedded that were created by eac. Cuesheets created by cdrdao/cueconvert work fine.
michael: can you attach a sample track to this bug?
I think I've figured out what was happening here. eac was spitting out wavs that didn't align to cd sector boundries. Audio::FLAC::Header treats this as an error which is technically the right thing to do. However, it appears that only the lead-out in the flac comments at the end of the cuesheet is affected, and slimserver doesn't actually use that value for anything. So it's probably worthwhile to see about being able to suck in the cuesheet in spite of this error, and process the rest of the data as normal. I'm not really sure how to do that without stomping on the error checking in the CPAN module, but I'll take another look at it after I've closed some of the more pressing bugs.
updating summary to better reflect the true core problem.
michael: what's the status of this?
I think the status of this would be best described as "enhancement request". We could add some sort of "lax checking" option to the cpan module, but I'm not sure if it's really the best idea. If no one else has stumbled across this yet besides myself, it may not be worth worrying about. I'm open to suggestions though.
I have a fix for this, but it involves adding a "less paranoia" option to the preferences (which will hopefully be useful to other areas of the app as well). I'm going to hold on to this one until after 6.1 is out, and folks have a chance to debate adding another pref, and produce translated strings, etc.
Created attachment 588 [details] lax checking for parsing with less paranoia attaching the fix so it doesn't get lost. (could probably still be polished a bit.)
is patch still valid? anything holding it back from 6.5?
Moving 7.4 bugs to 8.0.
This is no longer relevant as we no longer use Audio::FLAC::Header. Please reopen if you still have problems under 7.4+.