Bug 12843 - SN autoswitch doesn't work if inside the node
: SN autoswitch doesn't work if inside the node
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Networking
: unspecified
: PC Other
: P1 normal (vote)
: CAT
Assigned To: Wadzinski Tom
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-14 05:48 UTC by Wadzinski Tom
Modified: 2009-10-06 09:22 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wadzinski Tom 2009-07-14 05:48:27 UTC
Currently SN<->SC autoswitch only works for home menu items, not once you have entered the home menu item. For instance if you are connected to SC and are inside Pandora and SC goes down, instead of an autoswitch to SN dialog occuring, you will get a "reconnecting to the SC" sequence

Autoswitch works when it is known whether the other server (SN in the Pandora example) can serve the same content. Currently this is known by getting home menu items from SC and SN and when there are matching home menu item ids autoswitch can occur.

How to make this function deeper in a menu is not yet clear to me. One simple approach would be to examine the window stack to see what home menu item led to the current event, but this has several problems (the services aren't always entered via a top level menu item -"On Pandora" for example)

Another approach would be to use a unique service id for each service, and SC/SN would mark each menu item with which service is required to serve that item... Next I'll elicit feedback from Andy/Richard....
Comment 1 Wadzinski Tom 2009-07-14 11:56:52 UTC
Current plan is to use the cli command as a service identifier:
From campfire: 
Andy G.	
to fix another bug I have the server cache the browsing tree, so if you go to Rhapsody -> Features -> Albums For You, the contents won't change out from under you if you back up and then re-enter it
it also speeds up browsing quite a bit
so that's why you can't just take the same item_id and use it on another server. It will work but potentially the menu structure will be completely different
so prompting the user to go back home is probably the only solution
Tom W.	
right, agreed
Tom W.	
Andy, so here's a typical jsonAction (sent when clicking a menu item inside Amazon CD store)
View paste 
{ --[[table: 0x17485cc0]]
  cmd = { --[[table: 0x17491800]]
    "amazon",
    "items",
  },
  params = { --[[table: 0x17485dc0]]
    menu = "amazon",
    item_id = "e7ec1a9c.1.0.1",
  },
}
11:25 AM
Tom W.	
the string "amazon" is basically the unique service identifier
Andy G.	
yeah, there you go
Tom W.	
it's there twice, is there one that is the better one to identify the service by
Andy G.	
'amazon items' is the actual command, not sure what menu => amazon is there for
so I would use the first item in cmd
Tom W.	
ok. For starters my plan would be to hold a hardcoded mapping in SP of "menu id" to command identifier, such as amazon -> opmlamazon
Tom W.	
then I can test whether SN or SC can serve that service
Andy G.	
ok
Comment 2 Richard Titmuss 2009-07-27 01:09:47 UTC
Reset priority before triage.
Comment 3 Wadzinski Tom 2009-07-29 13:15:33 UTC
Plan is to offer "try again" and "go home", since it is difficult/impossible to autoswitch to the desired item.

Notes from campfire:

Tom W.	
Andy points out that while you are deep in a node, there isn't a way to autoswitch and have that request fulfilled
Tom W.	
so I am trying to figure out what the appropriate action to do in that case

Richard T.	
tom when we originally discussed this i think the options were "try again", or go home
Tom W.	
so autoswitch would then only happen at the top level, after they go home?
for instance, I'm deep in SC driven rhapsody and my SC goes down
Sound like from what you said, that auto-switch to SN doesn't happen when you click something, instead it offers "try again" and "go home". Once home then autoswitch to SN happens when you go back in. Sound right?
Would be an easy fix if so :)
Richard T.	
right. it'll be too hard to switch inside the tree
lets do the easy option, and see how much people complain :)
Comment 4 Wadzinski Tom 2009-07-29 13:45:33 UTC
fixed in r6845
Comment 5 James Richardson 2009-10-06 09:22:21 UTC
This bug has been fixed in the latest release of MySqueezebox.com (formally
known as SqueezeNetwork)!

If you are still experiencing this problem, feel free to reopen the bug with
your new comments and we'll have another look.